Skip to content

Conversation

@jrwishart
Copy link
Contributor

@jrwishart jrwishart commented Oct 16, 2025

Added unintentionally during some housekeeping in #90

@jrwishart jrwishart requested a review from JustinCCYap October 16, 2025 06:00
result <- result[result != ""]
result
}
result <- trimws(result)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that since the if case returns early, you can remove the else to reduce nesting and reduce the chance of these mistakes

Copy link
Contributor

@JustinCCYap JustinCCYap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comment

@jrwishart jrwishart merged commit 5678fed into master Oct 17, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants