Skip to content

ENG-1290: Port discourse node config panel #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sid597 wants to merge 2 commits into
base: eng-1291-port-discourse-node-specificationv1
Choose a base branch
from
+243 −102
Open

ENG-1290: Port discourse node config panel #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e3f7d6
ENG-1290: Port discourse node config panel
sid597 Feb 12, 2026
aeb08bf
fix bug
sid597 Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
254 changes: 154 additions & 100 deletions apps/roam/src/components/settings/DiscourseRelationConfigPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ import { formatHexColor } from "./DiscourseNodeCanvasSettings";
import posthog from "posthog-js";
import { getSetting, setSetting } from "~/utils/extensionSettings";
import { USE_REIFIED_RELATIONS } from "~/data/userSettings";
import {
setGlobalSetting,
getGlobalSettings,
} from "~/components/settings/utils/accessors";

const DEFAULT_SELECTED_RELATION = {
display: "none",
Expand Down Expand Up @@ -568,108 +572,147 @@ export const RelationEditPanel = ({
className="select-none"
onClick={() => {
setLoading(true);
setTimeout(async () => {
const rootUid = editingRelationInfo.uid;
setInputSetting({
blockUid: rootUid,
key: "source",
value: source,
});
setInputSetting({
blockUid: rootUid,
key: "destination",
value: destination,
index: 1,
});
setInputSetting({
blockUid: rootUid,
key: "complement",
value: complement,
index: 2,
});
updateBlock({
uid: rootUid,
text: label,
});
const ifUid =
editingRelationInfo.children.find((t) =>
toFlexRegex("if").test(t.text),
)?.uid ||
(await createBlock({
node: { text: "If" },
parentUid: rootUid,
order: 3,
}));
saveCyToElementRef(tab);
const blocks = tabs
.map((t) => elementsRef.current[t])
.map((elements) => ({
text: "And",
children: elements
.filter((e) => e.data.id.includes("-"))
.map((e) => {
const { source, target, relation } = e.data as {
source: string;
target: string;
relation: string;
};
return {
text: (
elements.find((e) => e.data.id === source)?.data as {
node: string;
}
)?.node,
children: [
{
text: relation,
setTimeout(
() =>
void (async () => {
const rootUid = editingRelationInfo.uid;
setInputSetting({
blockUid: rootUid,
key: "source",
value: source,
});
setInputSetting({
blockUid: rootUid,
key: "destination",
value: destination,
index: 1,
});
setInputSetting({
blockUid: rootUid,
key: "complement",
value: complement,
index: 2,
});
updateBlock({
uid: rootUid,
text: label,
});
const ifUid =
editingRelationInfo.children.find((t) =>
toFlexRegex("if").test(t.text),
)?.uid ||
(await createBlock({
node: { text: "If" },
parentUid: rootUid,
order: 3,
}));
saveCyToElementRef(tab);
const blocks = tabs
.map((t) => elementsRef.current[t])
.map((elements) => ({
text: "And",
children: elements
.filter((e) => e.data.id.includes("-"))
.map((e) => {
const { source, target, relation } = e.data as {
source: string;
target: string;
relation: string;
};
return {
text: (
elements.find((e) => e.data.id === source)
?.data as {
node: string;
}
)?.node,
children: [
{
text: ["source", "destination"].includes(target)
? target
: (
elements.find((e) => e.data.id === target)
?.data as { node: string }
)?.node,
text: relation,
children: [
{
text: ["source", "destination"].includes(
target,
)
? target
: (
elements.find(
(e) => e.data.id === target,
)?.data as { node: string }
)?.node,
},
],
},
],
};
})
.concat([
{
text: "node positions",
children: elements
.filter(
(
e,
): e is {
data: { id: string; node: unknown };
position: { x: number; y: number };
} => Object.keys(e).includes("position"),
)
.map((e) => ({
text: e.data.id,
children: [
{ text: `${e.position.x} ${e.position.y}` },
],
})),
},
],
};
})
.concat([
{
text: "node positions",
children: elements
.filter(
(
e,
): e is {
data: { id: string; node: unknown };
position: { x: number; y: number };
} => Object.keys(e).includes("position"),
)
.map((e) => ({
text: e.data.id,
children: [
{ text: `${e.position.x} ${e.position.y}` },
],
})),
},
]),
}));
await Promise.all(
getShallowTreeByParentUid(ifUid).map(({ uid }) =>
deleteBlock(uid),
),
);
await Promise.all(
blocks.map((block, order) =>
createBlock({ parentUid: ifUid, node: block, order }),
),
);
refreshConfigTree();
back();
}, 1);
]),
}));
await Promise.all(
getShallowTreeByParentUid(ifUid).map(({ uid }) =>
deleteBlock(uid),
),
);
await Promise.all(
blocks.map((block, order) =>
createBlock({ parentUid: ifUid, node: block, order }),
),
);
refreshConfigTree();

const ifConditions = blocks.map((block) => {
const positionsChild = block.children.find(
(c) => c.text === "node positions",
);
const triples = block.children
.filter((c) => c.text !== "node positions")
.map(
(c) =>
[
c.text,
c.children[0].text,
c.children[0].children[0].text,
] as [string, string, string],
);
const nodePositions = Object.fromEntries(
(positionsChild?.children ?? []).map((c) => [
c.text,
c.children[0].text,
]),
);
return { triples, nodePositions };
});
setGlobalSetting(["Relations", rootUid], {
label,
source,
destination,
complement,
ifConditions,
});

back();
})(),
1,
);
}}
/>
</div>
Expand Down Expand Up @@ -1030,6 +1073,9 @@ const DiscourseRelationConfigPanel: CustomField["options"]["component"] = ({
const handleDelete = (rel: Relation) => {
deleteBlock(rel.uid);
setRelations(relations.filter((r) => r.uid !== rel.uid));

const { [rel.uid]: _, ...remaining } = getGlobalSettings().Relations;
setGlobalSetting(["Relations"], remaining);
};
const handleDuplicate = (rel: Relation) => {
const baseText = rel.text
Expand Down Expand Up @@ -1059,7 +1105,15 @@ const DiscourseRelationConfigPanel: CustomField["options"]["component"] = ({
text,
children: stripUid(copyTree),
},
}).then((newUid) =>
}).then((newUid) => {
const originalRelation = getGlobalSettings().Relations[rel.uid];
if (originalRelation) {
setGlobalSetting(["Relations", newUid], {
...originalRelation,
label: text,
});
}

setRelations([
...relations,
{
Expand All @@ -1068,8 +1122,8 @@ const DiscourseRelationConfigPanel: CustomField["options"]["component"] = ({
destination: rel.destination,
text,
},
]),
);
]);
});
};
const handleBack = () => {
setEditingRelation("");
Expand Down
Loading