Precompile Fri Ext #993
Open
Precompile Fri Ext #993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnastaZIuk
commented
Jan 27, 2026
Comment on lines
+24
to
+29
| #ifndef NBL_EXT_FULLSCREEN_TRIANGLE_VS_ENTRYPOINT | ||
| #define NBL_EXT_FULLSCREEN_TRIANGLE_VS_ENTRYPOINT main | ||
| #endif | ||
|
|
||
| [shader("vertex")] | ||
| SVertexAttributes main() | ||
| SVertexAttributes NBL_EXT_FULLSCREEN_TRIANGLE_VS_ENTRYPOINT() |
There was a problem hiding this comment.
this is truly weird, couldn't we just name mangle the entrypoint? like __nbl__hlsl__ext__FullScreenTriangle__vertex_main ?
| public: | ||
| inline ProtoPipeline(asset::IAssetManager* assMan, video::ILogicalDevice* device, system::ILogger* logger=nullptr) | ||
| { | ||
| m_vxShader = createDefaultVertexShader(assMan,device,logger); |
There was a problem hiding this comment.
is there no way for this extension to have a builtin archive where the vertex shader is a precompiled .spv ?
Member
Author
There was a problem hiding this comment.
it's easy, if you want separate .spv I can get you one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.