Precompile Fri Ext #245
Open
Precompile Fri Ext #245
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Examples-and-Tests into fri_precomp_new_pt
Comment on lines
+42
to
+44
| // Precompile the FullScreenTriangle vertex shader along with this fragment shader. | ||
| #define NBL_EXT_FULLSCREEN_TRIANGLE_VS_ENTRYPOINT present_fri_ext | ||
| #include <nbl/builtin/hlsl/ext/FullScreenTriangle/default.vert.hlsl> |
There was a problem hiding this comment.
I don't like this solution, can we do something cleaner?
Member
Author
There was a problem hiding this comment.
ok we will do Devsh-Graphics-Programming/Nabla#993 (comment)
Comment on lines
+166
to
+168
| ext::FullScreenTriangle::ProtoPipeline fsTriProtoPln(shader, "present_fri_ext"); | ||
| if (!fsTriProtoPln) { logger.log("`CWindowPresenter::create` failed to create Full Screen Triangle protopipeline or load its vertex shader!",ILogger::ELL_ERROR); return false; } | ||
| m_present = fsTriProtoPln.createPipeline(fragSpec, layout.get(), getRenderpass()); |
There was a problem hiding this comment.
I actually wanted to just have the ext::FullScreenTriangle use a builtin .spv target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.