-
Notifications
You must be signed in to change notification settings - Fork 24
Feat: Implement comprehensive design revamp #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f19dff5
feat: Modernize group screens UI
google-labs-jules[bot] e0d3db9
feat: Apply modern theme to all screens and update home screen
google-labs-jules[bot] ccf234a
I will now fix the UI issues in the frontend.
google-labs-jules[bot] 38f65ba
I will fix the UI issues and implement the missing functionality.
google-labs-jules[bot] 6d75613
Refactor avatar handling across screens and introduce utility functions
Devasy 19ca52a
Revert "Refactor avatar handling across screens and introduce utility…
Devasy d5600b3
feat: Add skeleton loaders for Groups and Friends screens
google-labs-jules[bot] adc0e0a
Merge branch 'main' into fix/multiple-ui-issues
Devasy 6df2118
feat: Add skeleton loaders and animations to more screens
google-labs-jules[bot] 97b7538
Create Design Revamp.html
Devasy bad9a45
Update Design Revamp.html
Devasy 3433253
Feat: Implement comprehensive design revamp
google-labs-jules[bot] d0fd728
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1909f03
Fix: Correct JSX closing tag in MainNavigator
google-labs-jules[bot] 976f082
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import React, { useEffect } from "react"; | ||
| import { View, StyleSheet } from "react-native"; | ||
| import Animated, { | ||
| useSharedValue, | ||
| useAnimatedStyle, | ||
| withRepeat, | ||
| withTiming, | ||
| interpolateColor, | ||
| } from "react-native-reanimated"; | ||
| import { colors } from "../styles/theme"; | ||
|
|
||
| const SkeletonLoader = ({ style }) => { | ||
| const progress = useSharedValue(0); | ||
|
|
||
| useEffect(() => { | ||
| progress.value = withRepeat(withTiming(1, { duration: 1000 }), -1, true); | ||
| }, []); | ||
|
|
||
| const animatedStyle = useAnimatedStyle(() => { | ||
| const backgroundColor = interpolateColor( | ||
| progress.value, | ||
| [0, 1], | ||
| [colors.secondary, colors.white] | ||
| ); | ||
| return { | ||
| backgroundColor, | ||
| }; | ||
| }); | ||
|
|
||
| return <Animated.View style={[styles.skeleton, animatedStyle, style]} />; | ||
| }; | ||
|
|
||
| const styles = StyleSheet.create({ | ||
| skeleton: { | ||
| backgroundColor: colors.secondary, | ||
| borderRadius: 4, | ||
| }, | ||
| }); | ||
|
|
||
| export default SkeletonLoader; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| import React from 'react'; | ||
| import { TouchableOpacity, Text, StyleSheet, ActivityIndicator, Pressable } from 'react-native'; | ||
| import Animated, { useSharedValue, useAnimatedStyle, withTiming } from 'react-native-reanimated'; | ||
| import { colors, spacing, typography } from '../../styles/theme'; | ||
|
|
||
| const AnimatedPressable = Animated.createAnimatedComponent(Pressable); | ||
|
|
||
| const Button = ({ | ||
| title, | ||
| onPress, | ||
| mode = 'primary', // 'primary', 'secondary', 'tertiary' | ||
| disabled = false, | ||
| loading = false, | ||
| style, | ||
| textStyle, | ||
| ...props | ||
| }) => { | ||
| const scale = useSharedValue(1); | ||
|
|
||
| const animatedStyle = useAnimatedStyle(() => { | ||
| return { | ||
| transform: [{ scale: scale.value }], | ||
| }; | ||
| }); | ||
|
|
||
| const handlePressIn = () => { | ||
| scale.value = withTiming(0.98, { duration: 100 }); | ||
| }; | ||
|
|
||
| const handlePressOut = () => { | ||
| scale.value = withTiming(1, { duration: 100 }); | ||
| }; | ||
|
|
||
| const getButtonStyles = () => { | ||
| switch (mode) { | ||
| case 'secondary': | ||
| return styles.secondaryButton; | ||
| case 'tertiary': | ||
| return styles.tertiaryButton; | ||
| default: | ||
| return styles.primaryButton; | ||
| } | ||
| }; | ||
|
|
||
| const getTextStyles = () => { | ||
| switch (mode) { | ||
| case 'secondary': | ||
| return styles.secondaryText; | ||
| case 'tertiary': | ||
| return styles.tertiaryText; | ||
| default: | ||
| return styles.primaryText; | ||
| } | ||
| }; | ||
|
|
||
| const buttonStyle = [ | ||
| styles.button, | ||
| getButtonStyles(), | ||
| disabled && styles.disabled, | ||
| style, | ||
| ]; | ||
|
|
||
| const content = loading ? ( | ||
| <ActivityIndicator color={mode === 'primary' ? colors.neutral.white : colors.brandAccent} /> | ||
| ) : ( | ||
| <Text style={[styles.text, getTextStyles(), textStyle]}>{title}</Text> | ||
| ); | ||
|
|
||
| return ( | ||
| <AnimatedPressable | ||
| onPress={onPress} | ||
| onPressIn={handlePressIn} | ||
| onPressOut={handlePressOut} | ||
| disabled={disabled || loading} | ||
| style={[buttonStyle, animatedStyle]} | ||
| {...props} | ||
| > | ||
| {content} | ||
| </AnimatedPressable> | ||
| ); | ||
| }; | ||
|
|
||
| const styles = StyleSheet.create({ | ||
| button: { | ||
| paddingVertical: spacing.md, | ||
| paddingHorizontal: spacing.lg, | ||
| borderRadius: 12, | ||
| justifyContent: 'center', | ||
| alignItems: 'center', | ||
| flexDirection: 'row', | ||
| }, | ||
| text: { | ||
| ...typography.bodyBold, | ||
| textAlign: 'center', | ||
| }, | ||
| primaryButton: { | ||
| backgroundColor: colors.brandAccent, | ||
| }, | ||
| primaryText: { | ||
| color: colors.neutral.white, | ||
| }, | ||
| secondaryButton: { | ||
| backgroundColor: 'transparent', | ||
| borderWidth: 1.5, | ||
| borderColor: colors.brandAccent, | ||
| }, | ||
| secondaryText: { | ||
| color: colors.brandAccent, | ||
| }, | ||
| tertiaryButton: { | ||
| backgroundColor: 'transparent', | ||
| }, | ||
| tertiaryText: { | ||
| color: colors.brandAccent, | ||
| }, | ||
| disabled: { | ||
| backgroundColor: '#9CA3AF', | ||
| opacity: 0.7, | ||
| borderColor: 'transparent', | ||
| }, | ||
| }); | ||
|
|
||
| export default Button; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import React from 'react'; | ||
| import { View, StyleSheet, Platform } from 'react-native'; | ||
| import { BlurView } from 'expo-blur'; | ||
| import { colors, spacing } from '../../styles/theme'; | ||
|
|
||
| const Card = ({ children, style, intensity = 100, tint = 'light' }) => { | ||
| // The glassmorphic effect is a combination of a semi-transparent background and a blur. | ||
| // BlurView is not supported on all platforms (e.g., web, older Android), so we provide a fallback. | ||
| if (Platform.OS === 'ios' || Platform.OS === 'android') { | ||
| return ( | ||
| <View style={[styles.cardContainer, style]}> | ||
| <BlurView | ||
| style={styles.blurView} | ||
| intensity={intensity} | ||
| tint={tint} | ||
| > | ||
| {children} | ||
| </BlurView> | ||
| </View> | ||
| ); | ||
| } | ||
|
|
||
| // Fallback for platforms that don't support BlurView | ||
| return ( | ||
| <View style={[styles.cardContainer, styles.fallbackCard, style]}> | ||
| {children} | ||
| </View> | ||
| ); | ||
| }; | ||
|
|
||
| const styles = StyleSheet.create({ | ||
| cardContainer: { | ||
| borderRadius: 20, | ||
| overflow: 'hidden', | ||
| backgroundColor: 'transparent', | ||
| }, | ||
| blurView: { | ||
| padding: spacing.lg, | ||
| // The background color is set on the BlurView itself for a better effect | ||
| backgroundColor: 'rgba(255, 255, 255, 0.4)', | ||
| borderWidth: 1, | ||
| borderColor: 'rgba(255, 255, 255, 0.2)', | ||
| }, | ||
| fallbackCard: { | ||
| backgroundColor: colors.neutral.white, | ||
| padding: spacing.lg, | ||
| borderWidth: 1, | ||
| borderColor: colors.borderSubtle, | ||
| }, | ||
| }); | ||
|
|
||
| export default Card; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
Copilot Autofix
AI 5 months ago
To fix the problem, we should avoid returning exception details (message and type) directly to the user. Instead, return a generic error message such as
"An internal error has occurred"or"Failed to fetch expense details". For debugging purposes, the full exception details can be logged server-side using the existing logger (imported asloggerfromapp.config). This ensures developers can still access error information without exposing it to users. The change should be made in the exception handler of thedebug_expensefunction inbackend/app/expenses/routes.py, specifically replacing the return statement on line 511. Additionally, add a call tologger.error()to log the exception details.