Feat: Implement comprehensive design revamp #150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redesigned the group list and group details screens with a modern and bold UI. - Introduced a new color palette and typography theme for consistency. - Updated the layout of the group list and group details screens to be more intuitive and visually appealing. - Added animations and transitions to improve the user experience. - The new design is inspired by modern aesthetics to appeal to a younger audience.
- Applied the new modern theme to all screens for a consistent look and feel. - Refactored the home screen to a grid view for active groups. - Added an expander to the home screen to show/hide settled groups. - Updated the styling of all components to match the new design system.
- Updated EditProfileScreen to use centralized avatar logic for displaying user images or initials. - Refactored FriendsScreen to utilize new avatar utility functions for friend images and initials. - Enhanced GroupDetailsScreen with improved imports and structure. - Cleaned up GroupSettingsScreen by consolidating image handling and member rendering logic. - Improved HomeScreen to leverage avatar utilities for consistent display of group images and initials. - Added avatar utility functions: getInitial for generating initials from names and isValidImageUri for validating image URIs.
… functions" This reverts commit 6d75613.
This commit introduces a major overhaul of the application's design, based on the "Expressive Minimalism" philosophy outlined in the `Design Revamp.html` document. Key changes include: - A new color palette and typography scale have been implemented in `styles/theme.js`. - The "Inter" font family has been added and is now used throughout the app. - A new set of custom UI components (`Button`, `Card`, `Input`, `Header`) has been created in `components/v2/` to match the new aesthetic. - The `HomeScreen`, `AddExpenseScreen`, and `GroupDetailsScreen` have been completely redesigned using the new components and design system. - New screens for `AddGroupScreen` and `SettleUpScreen` have been created to provide a more focused user experience. - The main tab bar navigation has been restyled to match the new floating design. - Microinteractions, such as button press animations and a confetti effect for settling up, have been added to enhance the user experience.
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }, | ||
| } | ||
| except Exception as e: | ||
| return {"error": str(e), "type": type(e).__name__} |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 months ago
To fix the problem, we should avoid returning exception details (message and type) directly to the user. Instead, return a generic error message such as "An internal error has occurred" or "Failed to fetch expense details". For debugging purposes, the full exception details can be logged server-side using the existing logger (imported as logger from app.config). This ensures developers can still access error information without exposing it to users. The change should be made in the exception handler of the debug_expense function in backend/app/expenses/routes.py, specifically replacing the return statement on line 511. Additionally, add a call to logger.error() to log the exception details.
Suggested changeset
1
backend/app/expenses/routes.py
| @@ -508,4 +508,5 @@ | ||
| }, | ||
| } | ||
| except Exception as e: | ||
| return {"error": str(e), "type": type(e).__name__} | ||
| logger.error(f"Error in debug_expense: {e}", exc_info=True) | ||
| return {"error": "Failed to fetch expense details"} |
Copilot is powered by AI and may make mistakes. Always verify output.
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (15.38%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
==========================================
- Coverage 72.79% 72.35% -0.45%
==========================================
Files 17 17
Lines 1669 1682 +13
Branches 154 155 +1
==========================================
+ Hits 1215 1217 +2
- Misses 400 411 +11
Partials 54 54
🚀 New features to boost your workflow:
|
This commit fixes a typo in `frontend/navigation/MainNavigator.js` where a `</View>` tag was incorrectly written as `</V>`. This syntax error was causing the build to fail in the CI/CD pipeline.
for more information, see https://pre-commit.ci
|
🚀 Expo preview is ready!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a comprehensive design revamp of the mobile application, following the specifications in the
Design Revamp.htmlblueprint. The goal was to modernize the app's look and feel with a "Gen Z-centric" aesthetic called "Expressive Minimalism".The changes include a complete overhaul of the color scheme, typography, and component library. All major screens, including the a dashboard, expense tracking, and settlement flows, have been redesigned to align with the new visual identity.