Skip to content

fix: improve type safety in Grainient component #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidHDev merged 2 commits into from
Feb 9, 2026
Merged

fix: improve type safety in Grainient component #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59bd18a
fix: improve type safety in Grainient component
khoinguyenpham04 Feb 3, 2026
da17b25
fix: apply type safety improvements to ts-default Grainient
khoinguyenpham04 Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ts-default/Backgrounds/Grainient/Grainient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ const Grainient: React.FC<GrainientProps> = ({
const width = Math.max(1, Math.floor(rect.width));
const height = Math.max(1, Math.floor(rect.height));
renderer.setSize(width, height);
const res = program.uniforms.iResolution.value as Float32Array;
const res = (program.uniforms.iResolution as { value: Float32Array }).value;
res[0] = gl.drawingBufferWidth;
res[1] = gl.drawingBufferHeight;
};
Expand All @@ -221,7 +221,7 @@ const Grainient: React.FC<GrainientProps> = ({
let raf = 0;
const t0 = performance.now();
const loop = (t: number) => {
(program.uniforms.iTime as any).value = (t - t0) * 0.001;
(program.uniforms.iTime as { value: number }).value = (t - t0) * 0.001;
renderer.render({ scene: mesh });
raf = requestAnimationFrame(loop);
};
Expand Down
4 changes: 2 additions & 2 deletions src/ts-tailwind/Backgrounds/Grainient/Grainient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ const Grainient: React.FC<GrainientProps> = ({
const width = Math.max(1, Math.floor(rect.width));
const height = Math.max(1, Math.floor(rect.height));
renderer.setSize(width, height);
const res = program.uniforms.iResolution.value as Float32Array;
const res = (program.uniforms.iResolution as { value: Float32Array }).value;
res[0] = gl.drawingBufferWidth;
res[1] = gl.drawingBufferHeight;
};
Expand All @@ -220,7 +220,7 @@ const Grainient: React.FC<GrainientProps> = ({
let raf = 0;
const t0 = performance.now();
const loop = (t: number) => {
(program.uniforms.iTime as any).value = (t - t0) * 0.001;
(program.uniforms.iTime as { value: number }).value = (t - t0) * 0.001;
renderer.render({ scene: mesh });
raf = requestAnimationFrame(loop);
};
Expand Down