fix: improve type safety in Grainient component#871
Open
khoinguyenpham04 wants to merge 2 commits intoDavidHDev:mainfrom
Open
fix: improve type safety in Grainient component#871khoinguyenpham04 wants to merge 2 commits intoDavidHDev:mainfrom
khoinguyenpham04 wants to merge 2 commits intoDavidHDev:mainfrom
Conversation
Contributor
|
Hi @khoinguyenpham04, thanks for the PR! Replacing Could you also apply the same change in the ts-default file? Thanks! |
Author
|
Hi @Utkarsh-Singhal-26, thanks for reviewing my PR! I just applied the same changes to ts-default! Both files now use explicit types instead of as any. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 'as any' type assertions with specific types:
This improves type safety and prevents potential runtime errors.
Why: I love the new Grainient component and I used it in my codebase, however, after
npm run buildthere was a ts error, so I decided to fix it and create this PR. Hope this helps!