Skip to content

Use standard install destinations instead of ddprof/ prefix#518

Draft
r1viollet wants to merge 1 commit intomainfrom
r1viollet/fix/standard-install-destinations
Draft

Use standard install destinations instead of ddprof/ prefix#518
r1viollet wants to merge 1 commit intomainfrom
r1viollet/fix/standard-install-destinations

Conversation

@r1viollet
Copy link
Collaborator

@r1viollet r1viollet commented Mar 19, 2026

What does this PR do?

Install rules used a ddprof/ prefix on all destinations (bin, lib, include), producing non-standard paths like <prefix>/ddprof/bin/ddprof. This forced every consumer (Conan, cmake --install) to relocate files manually.

Remove the prefix and let CMAKE_INSTALL_PREFIX control the layout. Update setup_env.sh to set the prefix to ../deliverables/ddprof so the release tarball structure stays the same.

Motivation

See original PR here.

Additional Notes

NA

How to test the change?

Requires downstream PR in ddprof-build.
Custom pipeline is here

Install rules used a `ddprof/` prefix on all destinations (bin, lib,
include), producing non-standard paths like `<prefix>/ddprof/bin/ddprof`.
This forced every consumer (Conan, cmake --install) to relocate files
manually.

Remove the prefix and let `CMAKE_INSTALL_PREFIX` control the layout.
Update `setup_env.sh` to set the prefix to `../deliverables/ddprof` so
the release tarball structure stays the same.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@r1viollet
Copy link
Collaborator Author

I am not sure why the build status is not taking into account the custom build pipeline 🤔

@pr-commenter
Copy link

pr-commenter bot commented Mar 19, 2026

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.23.0+f1638cda.103549242 ddprof 0.23.0+a1fcc0f9.103564316

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter
Copy link

pr-commenter bot commented Mar 19, 2026

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.23.0+f1638cda.103549242 ddprof 0.23.0+a1fcc0f9.103564316

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 unsure
[+3.276ms; +14.567ms] or [+0.164%; +0.731%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants