Use standard install destinations instead of ddprof/ prefix#511
Closed
xroche wants to merge 1 commit intoDataDog:mainfrom
Closed
Use standard install destinations instead of ddprof/ prefix#511xroche wants to merge 1 commit intoDataDog:mainfrom
xroche wants to merge 1 commit intoDataDog:mainfrom
Conversation
Install rules used a `ddprof/` prefix on all destinations (bin, lib, include), producing non-standard paths like `<prefix>/ddprof/bin/ddprof`. This forced every consumer (Conan, cmake --install) to relocate files manually. Remove the prefix and let `CMAKE_INSTALL_PREFIX` control the layout. Update `setup_env.sh` to set the prefix to `../deliverables/ddprof` so the release tarball structure stays the same. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
xroche
force-pushed
the
fix/standard-install-destinations
branch
from
2e5dcc8 to
a1fcc0f
Compare
Collaborator
|
Copying the PR here to follow up on downstream build adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install rules used a
ddprof/prefix on all destinations, producing paths like<prefix>/ddprof/bin/ddprofinstead of the standard<prefix>/bin/ddprof. This breakscmake --install,find_package(), and Conan'scmake.install()without manual file relocation.The GNUInstallDirs convention expects
CMAKE_INSTALL_PREFIXto control the top-level directory, withbin/,lib/,include/directly underneath.How
Remove the
ddprof/prefix from install destinations and letCMAKE_INSTALL_PREFIXcontrol the layout. Updatesetup_env.shto append/ddprofto the install prefix so the release tarball keeps the sameddprof/bin/ddprofstructure.License files move from the install root to a
licenses/subdirectory. The tarball layout changes fromddprof/LICENSEtoddprof/licenses/LICENSE.🤖 Generated with Claude Code