Skip to content

Comments

Fix typos and improve translations in de.json5#5130

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
saschaszott:saschaszott-patch-19
Feb 20, 2026
Merged

Fix typos and improve translations in de.json5#5130
tdonohue merged 1 commit intoDSpace:mainfrom
saschaszott:saschaszott-patch-19

Conversation

@saschaszott
Copy link
Contributor

Description

This PR makes several minor corrections and improvements to the German translation file de.json5.

@lgeggleston lgeggleston added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Feb 20, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Feb 20, 2026
@pnbecker
Copy link
Member

@saschaszott thank you. The German parts looks good to me. The English comments should be identical to the entries in the English message catalogue. Then we can use the script to see changes between versions. Do you know if those typos are fixed in the English message catalogue as well?

+1

I’ll give Sascha the chance to answer to my question and will merge this rather sooner than later.

@saschaszott
Copy link
Contributor Author

@pnbecker , the typos in en.json5 were fixed in these PRs #5128 and #5129

@tdonohue tdonohue added this to the 10.0 milestone Feb 20, 2026
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @saschaszott ! Since the other typo-fix PRs were able to be backported to 8.x, I'm going to attempt to do the same here.

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Feb 20, 2026
@tdonohue tdonohue added port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Feb 20, 2026
@tdonohue tdonohue merged commit 7e4e662 into DSpace:main Feb 20, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Feb 20, 2026
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-9_x:

@tdonohue tdonohue removed port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants