Release: develop -> main#3581
Merged
TaprootFreak merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
* fix: support endpoint performance and null outputAsset crash Replace findOne+relations with explicit QueryBuilder joins in three support endpoints to avoid transitive eager-load fan-out through BuyCrypto.transaction / BuyFiat.transaction / BankTxReturn.transaction (all declared eager: true), which ballooned the query plan to 2-3s even for entities with no related rows. Also add optional chaining on targetEntity.outputAsset.name/blockchain in the support-issue transaction mapper to prevent a 500 when the referenced BuyCrypto has no outputAsset yet. Measured against DEV DB: - GET /v1/support/issue/:id/data: 2.3-4.0s -> 70-90ms - GET /v1/support/:id (user with 75 txns/19 issues): ~900ms -> ~700ms - GET /v1/support/:id/transaction-pdf: 650ms -> 200ms Response payloads verified byte-identical (after timezone normalization) across 5 users and 15 issues. * refactor: use loadEagerRelations:false instead of QueryBuilder Simpler alternative to the prior QueryBuilder rewrite for stopping transitive eager-load fan-out on support endpoints. Same query plan, ~10 lines less code, keeps idiomatic find() API.
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
TaprootFreak
approved these changes
Apr 20, 2026
Author
❌ Security: 3 critical vulnerabilities |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist