fix: override protobufjs to resolve critical vulnerability#3582
Merged
TaprootFreak merged 1 commit intodevelopfrom Apr 20, 2026
Merged
fix: override protobufjs to resolve critical vulnerability#3582TaprootFreak merged 1 commit intodevelopfrom
TaprootFreak merged 1 commit intodevelopfrom
Conversation
Add npm override for protobufjs >=7.5.5 to fix GHSA-xq3m-2v4x-88gg (arbitrary code execution). Resolves all 3 critical npm audit findings from transitive dependencies via @dhedge/v2-sdk and @buildonspark/spark-sdk.
davidleomay
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Override
protobufjsto>=7.5.5to fix all 3 critical npm audit vulnerabilities reported in the release PR #3581.Problem
npm auditreports 3 critical vulnerabilities, all caused by the same root issue: protobufjs < 7.5.5 is affected by GHSA-xq3m-2v4x-88gg — an arbitrary code execution vulnerability where a crafted protobuf message can execute arbitrary JavaScript code during parsing.The 3 critical findings are:
Root Cause
The vulnerable
protobufjsversions are deeply nested transitive dependencies that cannot be updated by bumping direct dependencies:@lyrafinance/lyra-jsis unmaintained and pinsfirebase@^9.9.4@dhedge/v2-sdkto v2.x doesn't help — it still depends on@lyrafinance/lyra-js@^0.0.20Fix
Add an npm override in
package.json:This forces all nested
protobufjsinstances (including the 6.x one) to resolve to a patched version. This is consistent with the existing override pattern already used in this project forbody-parser,qs,semver,multer, and others.Verification
npm auditcritical