-
Notifications
You must be signed in to change notification settings - Fork 24
docs: fix Datadog example -- correct endpoint, add required header and temporality env var #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
MichaelRuhwedel
wants to merge
1
commit into
DEVtheOPS:main
from
MichaelRuhwedel:fix/respect-metrics-temporality-preference
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: DEVtheOPS/opencode-plugin-otel
Length of output: 56
🏁 Script executed:
Repository: DEVtheOPS/opencode-plugin-otel
Length of output: 104
🏁 Script executed:
Repository: DEVtheOPS/opencode-plugin-otel
Length of output: 1072
🏁 Script executed:
Repository: DEVtheOPS/opencode-plugin-otel
Length of output: 223
🏁 Script executed:
# Look at the full context of config.ts to understand the pattern cat -n src/config.tsRepository: DEVtheOPS/opencode-plugin-otel
Length of output: 3264
Use
OPENCODE_prefix for plugin configuration variables.The documentation instructs users to set
OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCEdirectly, but this violates the plugin's established design pattern. All plugin configuration must use theOPENCODE_prefix (e.g.,OPENCODE_OTLP_HEADERS,OPENCODE_RESOURCE_ATTRIBUTES,OPENCODE_OTLP_ENDPOINT), which are then copied to theirOTEL_*equivalents before SDK initialization.The temporality preference should follow this same pattern:
Then in
src/config.ts, add handling to copy this toOTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCEbefore the SDK initializes (similar to the existingOPENCODE_OTLP_HEADERSandOPENCODE_RESOURCE_ATTRIBUTEShandling).🤖 Prompt for AI Agents