fix(clippy): allow unnecessary_sort_by and iter_without_into_iter lints#555
Merged
fix(clippy): allow unnecessary_sort_by and iter_without_into_iter lints#555
Conversation
These lints cause too many false positives across the codebase. - unnecessary_sort_by: Many valid uses for reverse sorting patterns - iter_without_into_iter: Not all iter() methods need IntoIterator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configures workspace-level Clippy lints to allow certain warnings that cause too many false positives.
Changes
Added to
[workspace.lints.clippy]:unnecessary_sort_by = "allow"- Many valid uses ofsort_bywith reverse comparisons throughout the codebaseiter_without_into_iter = "allow"- Not alliter()methods need a correspondingIntoIteratorimplementationWhy
These lints are generating hundreds of warnings across the codebase:
sort_by(|a, b| b.x.cmp(&a.x))is a common and valid pattern for reverse sortingiter()methods don't always needIntoIteratorwhen the use case is specificRather than modifying 50+ files, configuring these as allowed at the workspace level is the pragmatic solution.