fix(clippy): inherit workspace lints in all crates#556
Merged
Conversation
Add [lints] workspace = true to all workspace members to properly inherit the workspace-level Clippy lint configuration. For cortex-tui-core which has custom lints, add the workspace lint allows directly since Cargo doesn't support inheriting and overriding at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures all workspace members inherit the workspace-level Clippy lint configuration.
Changes
[lints] workspace = trueto all workspace member Cargo.toml files that didn't have itcortex-tui-corewhich has custom lint overrides, added the workspace lint allows directly since Cargo doesn't support inheriting and overriding at the same timeWhy
PR #555 added workspace-level lint configuration but the crates weren't configured to inherit it. This PR ensures all crates properly inherit the
unnecessary_sort_by = "allow"anditer_without_into_iter = "allow"lints.Affected Crates