Skip to content

Comments

fix(clippy): inherit workspace lints in all crates#556

Merged
echobt merged 1 commit intomasterfrom
fix/workspace-lints-1770010460
Feb 2, 2026
Merged

fix(clippy): inherit workspace lints in all crates#556
echobt merged 1 commit intomasterfrom
fix/workspace-lints-1770010460

Conversation

@echobt
Copy link
Contributor

@echobt echobt commented Feb 2, 2026

Summary

Ensures all workspace members inherit the workspace-level Clippy lint configuration.

Changes

  • Added [lints] workspace = true to all workspace member Cargo.toml files that didn't have it
  • For cortex-tui-core which has custom lint overrides, added the workspace lint allows directly since Cargo doesn't support inheriting and overriding at the same time

Why

PR #555 added workspace-level lint configuration but the crates weren't configured to inherit it. This PR ensures all crates properly inherit the unnecessary_sort_by = "allow" and iter_without_into_iter = "allow" lints.

Affected Crates

  • cortex-tui-framework and all cortex-tui-* crates
  • cortex-agents, cortex-batch, cortex-compact, cortex-experimental
  • cortex-ghost, cortex-hooks, cortex-linux-sandbox, cortex-lsp
  • cortex-migrations, cortex-plugins, cortex-ratelimits, cortex-resume
  • cortex-review, cortex-share, cortex-snapshot, cortex-storage
  • cortex-update, cortex-windows-sandbox, cortex-gui/cli

Add [lints] workspace = true to all workspace members to properly
inherit the workspace-level Clippy lint configuration.

For cortex-tui-core which has custom lints, add the workspace lint
allows directly since Cargo doesn't support inheriting and overriding
at the same time.
@echobt echobt merged commit cace37e into master Feb 2, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant