Skip to content

fix(scaffold): ConfigurationService::importFromApp 4-arg signature in template (closes #47) #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 1 commit into from
May 13, 2026
+35 −1
Merged

fix(scaffold): ConfigurationService::importFromApp 4-arg signature in template (closes #47) #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion lib/Resources/template/lib/Service/SettingsService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,42 @@ public function loadConfiguration(bool $force=false): array
}

try {
$configPath = __DIR__.'/../Settings/app_template_register.json';
if (file_exists($configPath) === false) {
$this->logger->error('AppTemplate: app_template_register.json not found at '.$configPath);
return [
'success' => false,
'message' => 'Configuration file app_template_register.json not found.',
];
}

$configContent = file_get_contents($configPath);
if ($configContent === false) {
$this->logger->error('AppTemplate: failed to read app_template_register.json');
return [
'success' => false,
'message' => 'Failed to read configuration file.',
];
}

$configData = json_decode($configContent, true);
if (json_last_error() !== JSON_ERROR_NONE) {
$this->logger->error('AppTemplate: failed to parse app_template_register.json: '.json_last_error_msg());
return [
'success' => false,
'message' => 'Failed to parse configuration file: '.json_last_error_msg(),
];
}

$configVersion = ($configData['info']['version'] ?? '0.0.0');

$configurationService = $this->container->get('OCA\OpenRegister\Service\ConfigurationService');
$result = $configurationService->importFromApp(appId: Application::APP_ID, force: $force);
$result = $configurationService->importFromApp(
appId: Application::APP_ID,
data: $configData,
version: $configVersion,
force: $force
);

if (empty($result) === false) {
$this->logger->info('AppTemplate: register configuration imported successfully');
Expand Down
Loading