fix(scaffold): ConfigurationService::importFromApp 4-arg signature in template (closes #47)#53
Merged
Conversation
… template (closes #47) The scaffold template's SettingsService called OpenRegister's ConfigurationService::importFromApp with the old 2-arg signature ($appId, $force). The signature changed to ($appId, array $data, string $version, bool $force), so every newly- scaffolded app inherited an ArgumentCountError at install/upgrade time. Load app_template_register.json from lib/Settings/ (the PlaceholderResolver substitutes app_template -> <slug> at scaffold time), extract info.version, and pass both to the 4-arg method. Mirrors the canonical fix shipped in decidesk#199 and shillinq#82. Fixes #47
Contributor
Quality Report — ConductionNL/openbuilt @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 432/432 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/19 statements)
Quality workflow — 2026-05-13 09:29 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scaffold template's
SettingsServicecalled OpenRegister'sConfigurationService::importFromAppwith the stale 2-arg signature ($appId, $force). The signature changed to($appId, array $data, string $version, bool $force), so every newly-scaffolded app inherited anArgumentCountErrorat install/upgrade time.Now loads
app_template_register.jsonfromlib/Settings/(PlaceholderResolver substitutesapp_template-><slug>at scaffold time), extractsinfo.version, and passes both to the 4-arg method.Mirrors the canonical fix in decidesk#199 and shillinq#82.
Fixes #47