ci(docs): fix beta Documentation deploy — generate compiled validator before styleguide build#334
Merged
Conversation
beta's Documentation deploy was failing: the styleguide build imports src/utils/validateManifestV2.compiled.js, a gitignored artifact produced by `npm run build:validators` (root prebuild hook). The styleguide sub-build never triggered that hook, so the file was missing and the build failed with "Module not found". Run root `npm ci` + `npm run build:validators` before the styleguide build so the compiled validator exists on disk.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
|
🎉 This PR is included in version 1.0.0-beta.70 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
beta's
Documentationdeploy has been failing (pre-existing) at the "Install and build component styleguide" step:src/utils/validateManifestV2.compiled.jsis gitignored and generated bynpm run build:validators(wired as the rootprebuildhook). The styleguide sub-build (cd styleguide && npm run build) never triggers the root prebuild, so the file is absent and the component sources can't resolve it.Fix
Run root
npm ci --legacy-peer-deps+npm run build:validatorsbefore the styleguide build, generating the validator on disk. Verified locally thatbuild:validatorswrites the 132KB file.CI note — admin merge expected
beta's
Code Quality(JSDoc ratchet) remains pre-existing-red across ~12 unrelated components (tracked in #333) — unrelated to this CI fix. branch-protection passes (hotfix→beta). Admin-merging to land the deploy fix; once merged, the Documentation deploy should go green and publish the architecture docs (configuration-over-code, atom-card page types, cn-domain-tree overview) merged in #332.