ci(docs): generate compiled validator in beta + dev styleguide deploy workflows#335
Merged
Merged
Conversation
Same fix as the main Documentation workflow, applied to the two sibling styleguide-snapshot workflows (documentation-beta.yml → /beta/styleguide, documentation-dev.yml → /dev/styleguide). Both build the styleguide without first generating src/utils/validateManifestV2.compiled.js, so they fail with "Module not found". Run root build:validators first.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
|
🎉 This PR is included in version 1.0.0-beta.70 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the main
documentation.ymlfix (#334). The two sibling styleguide-snapshot workflows have the same bug — they build the styleguide without first generating the gitignoredsrc/utils/validateManifestV2.compiled.js, failing withModule not found:documentation-beta.yml→/beta/styleguide/documentation-dev.yml→/dev/styleguide/Adds root
npm ci+npm run build:validatorsbefore each styleguide sub-build.CI note
beta
Code Quality(JSDoc ratchet) remains pre-existing-red (#333); branch-protection passes. Admin-merge to land the CI fix.