feat(i18n): Fix duplicate key and align translation files (277 keys)#59
Open
rubenvdlinde wants to merge 7 commits into
Open
feat(i18n): Fix duplicate key and align translation files (277 keys)#59rubenvdlinde wants to merge 7 commits into
rubenvdlinde wants to merge 7 commits into
Conversation
- Extend base webpack config instead of replacing resolve/module - Add NodePolyfillPlugin for process polyfill compatibility - Add CnObjectSidebar + objectSidebarState for proper sidebar positioning - Follows ADR-017 (component composition) and ADR-018 (header actions)
- webpack.config.js: disable splitChunks (NC serves chunks from wrong path), add SCSS rule, use NodePolyfillPlugin, extend base config not overwrite - router/index.js: static imports instead of lazy import() — prevents ChunkLoadError from /apps/ vs /custom_apps/ path mismatch - main.js: remove loadTranslations wrapper (blocks mount on l10n 404), use direct t/n imports matching procest pattern - package.json: upgrade @nextcloud/l10n ^2→^3.4.1, @conduction/nextcloud-vue beta.3→beta.7, fix apexcharts override ^3.45.0
- Replace custom HTML dashboard with CnDashboardPage component - KPI cards use CnStatsBlock with proper grid layout (4 cols each) - Move 'Bekijk alle' links to widget header-actions - Consistent with Procest/Pipelinq dashboard patterns
…Settings - router: replaced SettingsView with AdminRoot (same component used by NC admin panel at /settings/admin/decidesk), keeping both surfaces in sync - MainMenu: wrapped Settings link in NcAppNavigationSettings (gear icon widget) matching the Nextcloud UX convention for admin-only controls
Correct Nextcloud settings pattern (matching OpenCatalogi): - Admin config: /settings/admin/decidesk (NC admin panel via AdminSettings.php) - In-app settings: NcAppSettingsDialog modal from gear menu - Gear foldout (NcAppNavigationSettings) holds admin items + Settings - Settings click emits @open-settings, App.vue opens UserSettings modal - Removed /settings route from Vue router
- Remove duplicate key in en.json - Verify all 253 t() keys present in both l10n files
All translation keys now use sentence case per ADR-007. Only first word capitalized, except proper nouns and acronyms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t()/$this->l10n->t()translation callsl10n/en.json(identity-mapped) andl10n/nl.json(Dutch translations)<script setup>components missing directtimport from@nextcloud/l10nTest plan
🤖 Generated with Claude Code