Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/gate.yaml
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
name: Gate
on:
merge_group:
branches: [ 'master' ]

Check failure on line 4 in .github/workflows/gate.yaml

View workflow job for this annotation

GitHub Actions / Yaml Lint on Changed yaml files

4:25 [brackets] too many spaces inside brackets

Check failure on line 4 in .github/workflows/gate.yaml

View workflow job for this annotation

GitHub Actions / Yaml Lint on Changed yaml files

4:16 [brackets] too many spaces inside brackets
push:
branches: ['*', '!stabilization*', '!stable*', '!master' ]

Check failure on line 6 in .github/workflows/gate.yaml

View workflow job for this annotation

GitHub Actions / Yaml Lint on Changed yaml files

6:61 [brackets] too many spaces inside brackets
pull_request:
branches: [ 'master', 'stabilization*', 'oscal-update-*' ]

Check failure on line 8 in .github/workflows/gate.yaml

View workflow job for this annotation

GitHub Actions / Yaml Lint on Changed yaml files

8:61 [brackets] too many spaces inside brackets

Check failure on line 8 in .github/workflows/gate.yaml

View workflow job for this annotation

GitHub Actions / Yaml Lint on Changed yaml files

8:16 [brackets] too many spaces inside brackets
concurrency:
group: ${{ github.workflow }}-${{ github.event.number || github.run_id }}
cancel-in-progress: true
jobs:
validate-sle:
name: Build, Test on SLE 15 (Container)
name: Build, Test on SLE Latest (Container)
runs-on: ubuntu-latest
container:
image: registry.suse.com/bci/bci-base:latest
Expand All @@ -19,7 +19,7 @@
- name: Update CA certificates
run: update-ca-certificates
- name: Zypper add factory repo - to install bats and ShellCheck
run: zypper --non-interactive ar https://download.opensuse.org/repositories/openSUSE:/Backports:/SLE-15-SP5/standard/openSUSE:Backports:SLE-15-SP5.repo

Check failure on line 22 in .github/workflows/gate.yaml

View workflow job for this annotation

GitHub Actions / Yaml Lint on Changed yaml files

22:100 [line-length] line too long (160 > 99 characters)
- name: Zypper auto import keys
run: zypper --gpg-auto-import-keys --non-interactive ref
- name: Zypper refs
Expand All @@ -27,7 +27,7 @@
- name: Zypper refresh
run: zypper refresh
- name: Install Deps
run: zypper install -y git cmake make bats openscap-utils python3 python3-rpm python3-pip python3-devel python3-PyYAML python3-Jinja2 python3-setuptools libxslt-tools libxml2-tools ShellCheck

Check failure on line 30 in .github/workflows/gate.yaml

View workflow job for this annotation

GitHub Actions / Yaml Lint on Changed yaml files

30:100 [line-length] line too long (199 > 99 characters)
- name: Upgrade pip python
run: pip install pip --upgrade
- name: Install deps python
Expand All @@ -35,7 +35,7 @@
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4
- name: Build
run: ./build_product sle12 sle15
run: ./build_product sle12 sle15 sle16
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to change the name of the tests as well, probably to something more generic:

it contains reference to SLE 15 only Gate / Build, Test on SLE 15 (Container) (pull_request)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually the target testing container:

jobs:
  validate-sle:
    name: Build, Test on SLE 15 (Container)
    runs-on: ubuntu-latest
    container:
      image: registry.suse.com/bci/bci-base:latest
    steps:

in this case is image: registry.suse.com/bci/bci-base:latest which could be something higher than 15 I guess because of the latest, so changing to latest seems to be more accurate.

- name: Test
run: ctest -j$(nproc) --output-on-failure -E unique-stigids
working-directory: ./build
Expand All @@ -47,7 +47,7 @@
image: opensuse/leap:15
steps:
- name: Install Deps
run: zypper install -y git cmake make openscap-utils python3-PyYAML bats python3-pytest python3-pytest-cov python3-Jinja2 python3-setuptools libxslt-tools libxml2-tools ShellCheck

Check failure on line 50 in .github/workflows/gate.yaml

View workflow job for this annotation

GitHub Actions / Yaml Lint on Changed yaml files

50:100 [line-length] line too long (187 > 99 characters)
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4
- name: Build
Expand All @@ -67,13 +67,13 @@
- name: Update the package repository
run: apt-get update
- name: Install Deps
run: apt-get install -y ansible-lint bats check cmake openscap-scanner openscap-utils libxml2-utils ninja-build python3-pip xsltproc libxslt1-dev libxml2-dev zlib1g-dev python3.11-venv

Check failure on line 70 in .github/workflows/gate.yaml

View workflow job for this annotation

GitHub Actions / Yaml Lint on Changed yaml files

70:100 [line-length] line too long (192 > 99 characters)
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4
- name: Upgrade pip python
run: pip install --upgrade pip --break-system-packages
- name: Install deps python
run: pip3 install -r requirements.txt -r test-requirements.txt --ignore-installed PyYAML PyGithub --break-system-packages

Check failure on line 76 in .github/workflows/gate.yaml

View workflow job for this annotation

GitHub Actions / Yaml Lint on Changed yaml files

76:100 [line-length] line too long (129 > 99 characters)
- name: Build
env:
ADDITIONAL_CMAKE_OPTIONS: "-DSSG_ANSIBLE_PLAYBOOKS_PER_RULE_ENABLED=ON -DSSG_OVAL_SCHEMATRON_VALIDATION_ENABLED=OFF"
Expand Down
Loading