Add SLE16 to SUSE gating#14742
Conversation
|
This will fail until #14741 is merged. |
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4 | ||
| - name: Build | ||
| run: ./build_product sle12 sle15 | ||
| run: ./build_product sle12 sle15 sle16 |
There was a problem hiding this comment.
It makes sense to change the name of the tests as well, probably to something more generic:
it contains reference to SLE 15 only Gate / Build, Test on SLE 15 (Container) (pull_request)
There was a problem hiding this comment.
actually the target testing container:
jobs:
validate-sle:
name: Build, Test on SLE 15 (Container)
runs-on: ubuntu-latest
container:
image: registry.suse.com/bci/bci-base:latest
steps:
in this case is image: registry.suse.com/bci/bci-base:latest which could be something higher than 15 I guess because of the latest, so changing to latest seems to be more accurate.
It's using the following container image: registry.suse.com/bci/bci-base:latest so it can be something later than SLE15.
ggbecker
force-pushed
the
add_sle16_to_workflow
branch
from
60f9ca6 to
af2d6f3
Compare
|
I have rebased on latest main branch after merging #14741 and added one more change to the title of the test. |
|
@Mab879: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Description:
Add SLE16 to SUSE gating
Rationale:
Review Hints:
Double check that SLE16 was build in CI.