Solve cursor movement on custom workplane sometimes not working#72
Open
rondlh wants to merge 1 commit intoCommonWealthRobotics:developmentfrom
Open
Solve cursor movement on custom workplane sometimes not working#72rondlh wants to merge 1 commit intoCommonWealthRobotics:developmentfrom
rondlh wants to merge 1 commit intoCommonWealthRobotics:developmentfrom
Conversation
Solve cursor movement not working
Member
|
This exception was added to act as a feedback channel for invalid transform moves being added to the timeline. I guess we can roll that back. but it may be better to handle the exception rather than to fail to throw it in all cases, as some code depends on detecting the invalid transform to throw an exception to be handled correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
=== REVIEW BEFORE MERGE===
Solve cursor movement not working.
Sometimes the object doesn't move on a custom work plane when the cursor keys are pressed, then this exception is thrown:
Error com.neuronrobotics.sdk.common.Log:error:
It is thrown here:
public MoveCenter setLocation(TransformNR location) throws InvalidLocationMove {
I am not sure why isWorkplaneNotOrigin is required here. The provided "location" seems to be the object location relative to the custom work plane. In "location" no rotation is present, and the object "translation" is relative to the custom work plane. That means that when object goes through the origin the exception is thrown and the object does not move.
Here is the data that "location" holds:
This PR removes the requirement of "isWorkplaneNotOrigin" for saving the new object location.