Skip to content

Fix PascalCase parameter naming to follow C# conventions #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix PascalCase parameter naming to follow C# conventions #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fa708e
Initial plan
Copilot Nov 30, 2025
e2e7564
Fix inconsistent PascalCase parameter naming to camelCase in ImageCom…
Copilot Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions SkiaSharpCompare/ImageCompare.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,18 +117,18 @@ public ICompareResult CalcDiff(SKBitmap pic1, SKBitmap pic2)
/// <summary>
/// Calculates the difference between two in-memory images represented as <see cref="SKBitmap"/> objects.
/// </summary>
/// <param name="Pic1"></param>
/// <param name="Pic2"></param>
/// <param name="pic1"></param>
/// <param name="pic2"></param>
/// <param name="differenceMaskPic"></param>
/// <returns></returns>
public ICompareResult CalcDiff(SKBitmap Pic1, SKBitmap Pic2, SKBitmap differenceMaskPic)
public ICompareResult CalcDiff(SKBitmap pic1, SKBitmap pic2, SKBitmap differenceMaskPic)
{
if (CompareMetadata)
{
throw new NotSupportedException("Metadata comparison is not implemented for SKBitmap inputs. https://github.com/mono/SkiaSharp/issues/1139 Use the overload with streams or filepath to get support for metadata comparison.");
}

return Compare.CalcDiff(Pic1, Pic2, differenceMaskPic, ResizeOption, PixelColorShiftTolerance, TransparencyOptions);
return Compare.CalcDiff(pic1, pic2, differenceMaskPic, ResizeOption, PixelColorShiftTolerance, TransparencyOptions);
}

/// <summary>
Expand Down Expand Up @@ -173,23 +173,23 @@ public ICompareResult CalcDiff(Stream pic1, Stream pic2, SKBitmap maskImage)
/// <summary>
/// Calculates a difference mask image that highlights the differences between two images located at the specified file paths.
/// </summary>
/// <param name="PathPic1"></param>
/// <param name="PathPic2"></param>
/// <param name="pathPic1"></param>
/// <param name="pathPic2"></param>
/// <returns></returns>
public SKBitmap CalcDiffMaskImage(string PathPic1, string PathPic2)
public SKBitmap CalcDiffMaskImage(string pathPic1, string pathPic2)
{
return Compare.CalcDiffMaskImage(PathPic1, PathPic2, ResizeOption, PixelColorShiftTolerance, TransparencyOptions);
return Compare.CalcDiffMaskImage(pathPic1, pathPic2, ResizeOption, PixelColorShiftTolerance, TransparencyOptions);
}

/// <summary>
/// Calculates a difference mask image that highlights the differences between two in-memory images represented as <see cref="SKBitmap"/> objects.
/// </summary>
/// <param name="Pic1"></param>
/// <param name="Pic2"></param>
/// <param name="pic1"></param>
/// <param name="pic2"></param>
/// <returns></returns>
public SKBitmap CalcDiffMaskImage(SKBitmap Pic1, SKBitmap Pic2)
public SKBitmap CalcDiffMaskImage(SKBitmap pic1, SKBitmap pic2)
{
return Compare.CalcDiffMaskImage(Pic1, Pic2, ResizeOption, PixelColorShiftTolerance, TransparencyOptions);
return Compare.CalcDiffMaskImage(pic1, pic2, ResizeOption, PixelColorShiftTolerance, TransparencyOptions);
}

/// <summary>
Expand Down Expand Up @@ -242,12 +242,12 @@ public SKBitmap CalcDiffMaskImage(SKBitmap image1, SKBitmap image2, SKBitmap dif
/// <summary>
/// Checks if two images located at the specified file paths are identical, considering the configured options for resizing,
/// </summary>
/// <param name="PathActual"></param>
/// <param name="PathExpected"></param>
/// <param name="pathActual"></param>
/// <param name="pathExpected"></param>
/// <returns></returns>
public bool ImagesAreEqual(string PathActual, string PathExpected)
public bool ImagesAreEqual(string pathActual, string pathExpected)
{
return Compare.ImagesAreEqual(PathActual, PathExpected, ResizeOption, PixelColorShiftTolerance, TransparencyOptions, CompareMetadata);
return Compare.ImagesAreEqual(pathActual, pathExpected, ResizeOption, PixelColorShiftTolerance, TransparencyOptions, CompareMetadata);
}

/// <summary>
Expand Down Expand Up @@ -275,12 +275,12 @@ public bool ImagesAreEqual(SKBitmap actual, SKBitmap expected)
/// <summary>
/// Checks if two images have the same dimensions (width and height).
/// </summary>
/// <param name="PathActual"></param>
/// <param name="PathExpected"></param>
/// <param name="pathActual"></param>
/// <param name="pathExpected"></param>
/// <returns></returns>
public static bool ImagesHaveEqualSize(string PathActual, string PathExpected)
public static bool ImagesHaveEqualSize(string pathActual, string pathExpected)
{
return Compare.ImagesHaveEqualSize(PathActual, PathExpected);
return Compare.ImagesHaveEqualSize(pathActual, pathExpected);
}
}
}