Skip to content

Conversation

Copy link

Copilot AI commented Nov 30, 2025

Parameters in ImageCompare.cs used inconsistent PascalCase naming (Pic1, Pic2, PathActual, etc.) instead of camelCase, violating C# conventions and inconsistent with other parameters in the same file.

Changes

  • CalcDiff(SKBitmap Pic1, SKBitmap Pic2, ...)CalcDiff(SKBitmap pic1, SKBitmap pic2, ...)
  • CalcDiffMaskImage(string PathPic1, string PathPic2)CalcDiffMaskImage(string pathPic1, string pathPic2)
  • CalcDiffMaskImage(SKBitmap Pic1, SKBitmap Pic2)CalcDiffMaskImage(SKBitmap pic1, SKBitmap pic2)
  • ImagesAreEqual(string PathActual, string PathExpected)ImagesAreEqual(string pathActual, string pathExpected)
  • ImagesHaveEqualSize(string PathActual, string PathExpected)ImagesHaveEqualSize(string pathActual, string pathExpected)

XML doc <param> tags updated to match.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

…pare.cs

Co-authored-by: stesee <168659+stesee@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback on diff metadata pull request Fix PascalCase parameter naming to follow C# conventions Nov 30, 2025
Copilot AI requested a review from stesee November 30, 2025 15:37
@stesee stesee closed this Dec 6, 2025
@stesee stesee deleted the copilot/sub-pr-75-yet-again branch December 6, 2025 12:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants