-
-
Notifications
You must be signed in to change notification settings - Fork 498
London | May - 26 | Liridona Shehu | Sprint 2 | Wireframe #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shehu-dona
wants to merge
3
commits into
CodeYourFuture:main
Choose a base branch
from
shehu-dona:feature/wireframe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−5
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,13 +15,38 @@ <h1>Wireframe</h1> | |
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <img src="https://docs.github.com/assets/cb-69181/images/help/repository/headings-toc.png" alt="read.md img"/> | ||
| <h2>Read Me File</h2> | ||
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| A README file explains what a project is and how to use it. It’s usually the first file people read when they open a | ||
| project, especially in software development. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| <a href="https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes">Read more</a> | ||
| </article> | ||
| <article> | ||
| <img src="https://cdn-images.visual-paradigm.com/handbooks/agile-handbook/wireframe/02-newspaper-site-wireframe-example.png" alt="wireframe img"/> | ||
| <h2>What is the purpose of a wireframe?</h2> | ||
| <p> | ||
| A wireframe is a simple visual layout of a website, app, or software interface. Its purpose is to show the structure and | ||
| arrangement of content before detailed design and development begin. | ||
| </p> | ||
| <a href="https://balsamiq.com/blog/what-are-wireframes/">Read More</a> | ||
| </article> | ||
| <article> | ||
| <img src="https://nulab.com/static/2b1b3450c0069d0cbd97d70e48c7a81c/5a190/02.png" alt="Git Branch img"/> | ||
| <h2>What is a branch in Git?</h2> | ||
| <p> | ||
| A branch in Git is a separate line of development that lets you work on changes without affecting the main project. | ||
|
|
||
| Think of it like creating a copy of your project where you can safely:<br> | ||
|
|
||
| Add new features<br> | ||
| Fix bugs<br> | ||
| Test ideas<br> | ||
|
|
||
| while the original code remains unchanged. | ||
|
Comment on lines
+41
to
+47
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using Can you find a more suitable HTML elements, with or without using CSS, to list the three phrases on line 43-45? |
||
| </p> | ||
| <a href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches">Read More</a> | ||
| </article> | ||
| </main> | ||
| <footer> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Providing meaningful
alttext is important because it ensures images are accessible to people using screen readers and also helps when imagesfail to load, giving users essential context about the content or function of the image.
Can you think of a more descriptive
altvalue to every image?