Skip to content

London | May - 26 | Liridona Shehu | Sprint 2 | Wireframe#1371

Open
shehu-dona wants to merge 3 commits into
CodeYourFuture:mainfrom
shehu-dona:feature/wireframe
Open

London | May - 26 | Liridona Shehu | Sprint 2 | Wireframe#1371
shehu-dona wants to merge 3 commits into
CodeYourFuture:mainfrom
shehu-dona:feature/wireframe

Conversation

@shehu-dona
Copy link
Copy Markdown

@shehu-dona shehu-dona commented May 30, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Wireframe project completed. It has 2 articles with 3 different images and links.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 30, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit b3e66b7
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1acbdc958b8800088645c0
😎 Deploy Preview https://deploy-preview-1371--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@shehu-dona shehu-dona changed the title London| May-26 | Liridona Shehu | Sprint-2 | Wireframe London | May-26 | Liridona Shehu | Sprint-2 | Wireframe May 30, 2026
@github-actions

This comment has been minimized.

@shehu-dona shehu-dona changed the title London | May-26 | Liridona Shehu | Sprint-2 | Wireframe London | May-26 | Liridona Shehu | Sprint 2| Wireframe May 30, 2026
@github-actions

This comment has been minimized.

@shehu-dona shehu-dona changed the title London | May-26 | Liridona Shehu | Sprint 2| Wireframe London | May - 26 | Liridona Shehu | Sprint 2 | Wireframe May 30, 2026
@github-actions

This comment has been minimized.

@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

8 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@shehu-dona shehu-dona added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • To better match the wireframe, can you
    • Keep the page title and text beneath it centered on the page
    • Make the title of articles 2 and 3 fully aligned horizontally
    • Prevent the footer and article content overlap
Image

Comment thread Wireframe/index.html
Comment on lines 11 to 14
<h1>Wireframe</h1>
<p>
This is the default, provided code and no changes have been made yet.
</p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also replace these placeholder text?

Comment thread Wireframe/index.html
<article>
<img src="placeholder.svg" alt="" />
<h2>Title</h2>
<img src="https://docs.github.com/assets/cb-69181/images/help/repository/headings-toc.png" alt="read.md img"/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images
fail to load, giving users essential context about the content or function of the image.

Can you think of a more descriptive alt value to every image?

Comment thread Wireframe/index.html
Comment on lines +41 to +47
Think of it like creating a copy of your project where you can safely:<br>

Add new features<br>
Fix bugs<br>
Test ideas<br>

while the original code remains unchanged.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using <br> to force line break is a poor practice.

Can you find a more suitable HTML elements, with or without using CSS, to list the three phrases on line 43-45?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants