Skip to content

Manchester | 26-ITP-May | Ahmed Elmahmoudi | Sprint 1 | Feature/Form-controls #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alaterry8 wants to merge 8 commits into
base: main
Choose a base branch
from
+80 −28
Open

Manchester | 26-ITP-May | Ahmed Elmahmoudi | Sprint 1 | Feature/Form-controls #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa4a57b
Add css file and requirements
Alaterry8 May 29, 2026
519b693
Fix name and add email section
Alaterry8 May 29, 2026
beb5289
Add colour options
Alaterry8 May 29, 2026
81d7765
Add size options
Alaterry8 May 29, 2026
7f43f3e
Add required attrinute to sizes
Alaterry8 May 29, 2026
2261aa0
Add spacing between size options
Alaterry8 May 29, 2026
c754a40
Tick off requirements
Alaterry8 May 29, 2026
91c5ee2
Add changes to README.md
Alaterry8 May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions Form-Controls/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@

<!--{{<objectives>}}>-->

- [ ] Interpret requirements and check against a list of criteria
- [ ] Write a valid form
- [ ] Test with Devtools
- [ ] Refactor using Devtools
- [ ] Use version control by committing often and pushing regularly to GitHub
- [ ] Develop the habit of writing clean, well-structured, and error-free code
- [x] Interpret requirements and check against a list of criteria
- [x] Write a valid form
- [x] Test with Devtools
- [x] Refactor using Devtools
- [x] Use version control by committing often and pushing regularly to GitHub
- [x] Develop the habit of writing clean, well-structured, and error-free code
<!--{{<objectives>}}>-->

## Task
Expand Down Expand Up @@ -39,18 +39,18 @@ Do not write a form action for this project.

Let's write out our testable criteria. Check each one off as you complete it.

- [ ] I have only used HTML and CSS.
- [ ] I have not used any JavaScript.
- [x] I have only used HTML and CSS.
- [x] I have not used any JavaScript.

### HTML

- [ ] My form is semantic HTML.
- [ ] All inputs have associated labels.
- [ ] My Lighthouse Accessibility score is 100.
- [ ] I require a valid name.
- [ ] I require a valid email.
- [ ] I require one colour from a defined set of 3 colours.
- [ ] I require one size from a defined set of 6 sizes.
- [x] My form is semantic HTML.
- [x] All inputs have associated labels.
- [x] My Lighthouse Accessibility score is 100.
- [x] I require a valid name.
- [x] I require a valid email.
- [x] I require one colour from a defined set of 3 colours.
- [x] I require one size from a defined set of 6 sizes.

### Developers must adhere to professional standards.

Expand All @@ -59,10 +59,10 @@ Let's write out our testable criteria. Check each one off as you complete it.
These practices reflect the level of quality expected in professional work.
They ensure your code is reliable, maintainable, and presents a polished, credible experience to users.

- [ ] My HTML code has no errors or warnings when validated using https://validator.w3.org/
- [ ] My code is consistently formatted
- [ ] My page content is free of typos and grammatical mistakes
- [ ] I commit often and push regularly to GitHub
- [x] My HTML code has no errors or warnings when validated using https://validator.w3.org/
- [x] My code is consistently formatted
- [x] My page content is free of typos and grammatical mistakes
- [x] I commit often and push regularly to GitHub

## Resources
- [MDN: Form controls](https://developer.mozilla.org/en-US/docs/Learn/Forms)
Expand Down
70 changes: 61 additions & 9 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
Expand All @@ -7,21 +7,73 @@
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>

<body>
<header>
<h1>Product Pick</h1>
</header>

<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<form class="form">
Copy link
Copy Markdown

@Luro91 Luro91 May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on all validations


<div>
<label for="name"> Name:</label>
<input type="text" name="name" id="name" minlength="2" required />
<br><br>

<label for="email"> Email:</label>
<input type="email" name="email" id="email" required>
<br><br>

<label for="colour">Colour:</label>
<select name="colour" id="colour" required>
<option value="" selected disabled> Select</option>
<option value="red"> Red</option>
<option value="green">Green</option>
<option value="blue">Blue</option>
</select>
<br><br>

<fieldset>
<legend>Size</legend>

<label for="XS"> XS</label>
Comment on lines +29 to +40
Copy link
Copy Markdown

@Luro91 Luro91 May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I would switch around the form types. Radio buttons are good if there are not to many options to choose from. Space on a web page is precious and for inputs with a lot of options a dropddown can save a lot of space. (You don't need to change anything. This is just an information on the different input types)

<input type="radio" name="size" id="XS" value="XS" required>
<br><br>

<label for="S">S</label>
<input type="radio" name="size" id="S" value="S">
<br><br>

<label for="M"> M</label>
<input type="radio" name="size" id="M" value="M">
<br><br>

<label for="L"> L</label>
<input type="radio" name="size" id="L" value="L">
<br><br>

<label for="XL"> XL</label>
<input type="radio" name="size" id="XL" value="XL">
<br><br>

<label for="XXL"> XXL</label>
<input type="radio" name="size" id="XXL" value="XXL">
<br><br>

</fieldset>

<br>
<button type="submit">Submit</button>
</div>



</form>
</main>
</main>

<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>By Ahmed Elmahmoudi</p>
</footer>
</body>
</html>