Manchester | 26-ITP-May | Ahmed Elmahmoudi | Sprint 1 | Feature/Form-controls#1367
Open
Alaterry8 wants to merge 7 commits into
Open
Manchester | 26-ITP-May | Ahmed Elmahmoudi | Sprint 1 | Feature/Form-controls#1367Alaterry8 wants to merge 7 commits into
Alaterry8 wants to merge 7 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Alaterry8
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
May 30, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
How can you achieve a lighthouse score of in all categories 100?
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <form class="form"> |
Comment on lines
+29
to
+40
| <select name="colour" id="colour" required> | ||
| <option value="" selected disabled> Select</option> | ||
| <option value="red"> Red</option> | ||
| <option value="green">Green</option> | ||
| <option value="blue">Blue</option> | ||
| </select> | ||
| <br><br> | ||
|
|
||
| <fieldset> | ||
| <legend>Size</legend> | ||
|
|
||
| <label for="XS"> XS</label> |
There was a problem hiding this comment.
FYI: I would switch around the form types. Radio buttons are good if there are not to many options to choose from. Space on a web page is precious and for inputs with a lot of options a dropddown can save a lot of space. (You don't need to change anything. This is just an information on the different input types)
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist