Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions Sprint-2/implement_linked_list/linked_list.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
class Node:
def __init__(self, value):
self.value = value
self.prev = None
self.next = None

class LinkedList:
def __init__(self):
self.head = None
self.tail = None

def push_head(self, value):
new_node = Node(value)
new_node.next = self.head
new_node.prev = None

if self.head is not None:
self.head.prev = new_node
self.head = new_node

if self.tail is None:
self.tail = new_node

return new_node

def pop_tail(self):
if self.tail is None:
return
node_to_be_removed = self.tail
self.remove(node_to_be_removed)
return node_to_be_removed.value

def remove(self, node):
if node.prev is not None:
node.prev.next = node.next
else:
self.head = node.next
if node.next is not None:
node.next.prev = node.prev
if node == self.tail:
self.tail = node.prev
node.prev = None
node.next = None
Comment on lines +42 to +43
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of the code on lines 48, 49? Why not do the same to node_to_be_removed in pop_tail()?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made changes according to the review.