London | 25-SDC-July | Eyuel Abraham | Sprint 2 | Linked list implementation.#79
Open
eyuell21 wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
London | 25-SDC-July | Eyuel Abraham | Sprint 2 | Linked list implementation.#79eyuell21 wants to merge 3 commits intoCodeYourFuture:mainfrom
eyuell21 wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
eyuell21
added
the
Needs Review
cjyuan
reviewed
Jan 23, 2026
Comment on lines
+48
to
+49
| node.prev = None | ||
| node.next = None |
There was a problem hiding this comment.
What's the purpose of the code on lines 48, 49? Why not do the same to node_to_be_removed in pop_tail()?
Author
There was a problem hiding this comment.
I've made changes according to the review.
cjyuan
added
Reviewed
cjyuan
reviewed
Mar 3, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Don't forget to change label if the PR is ready to be re-reviewed.
Comment on lines
+37
to
+38
| node_to_be_removed.prev = None | ||
| node_to_be_removed.next = None |
There was a problem hiding this comment.
-
One of these two statements is optional.
-
Better still, delegate the node removing task (lines 30-38) to
remove()-- less code to maintain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Linked list implementation.
Questions
No Questions