⚡ Bolt: [performance improvement] Optimize configuration loading for bulk worktree creations

.jules/bolt.md

@@ -4,3 +4,6 @@
 ## 2026-05-16 - [Batch FeathersJS user fetches with $in operator to fix N+1 query]
 **Learning:** FeathersJS allows passing `$in` clauses through the query parameter (e.g. `user_id: { $in: ownerIds }`). When writing custom Feathers service logic, you can easily parse this array and pass it to Drizzle's `inArray()` to perform a batched query, instead of looping over `service.get(id)` causing N+1 database roundtrips.
 **Action:** When implementing or updating custom Feathers `find()` methods, extract and parse the `$in` parameters to support batched Drizzle `inArray()` lookups, and always replace `Promise.all(ids.map(id => service.get(id)))` with a single batched `find()` call.
+## 2024-05-30 - [Optimize bulk operations reading disk configurations]
+**Learning:** The `loadConfig()` function reads and parses YAML files on every invocation. Placing this function inside a loop (like `Array.prototype.map` combined with `Promise.all` inside bulk inserts) results in multiple unnecessary asynchronous IO operations and parses. This scales poorly and increases operation latency linearly per item O(N).
+**Action:** When performing bulk creations or mappings, check if configuration variables are needed. Fetch them once *before* the loop and pass them as optional arguments into child handlers/formatting functions to minimize disk and parsing overhead.

apps/agor-daemon/src/services/worktrees.ts

@@ -10,7 +10,13 @@ import { existsSync } from 'node:fs';
 import { mkdir } from 'node:fs/promises';
 import { homedir } from 'node:os';
 import { dirname, join } from 'node:path';
-import { ENVIRONMENT, isWorktreeRbacEnabled, loadConfig, PAGINATION } from '@agor/core/config';
+import {
+  type AgorConfig,
+  ENVIRONMENT,
+  isWorktreeRbacEnabled,
+  loadConfig,
+  PAGINATION,
+} from '@agor/core/config';
 import { type Database, WorktreeRepository, type WorktreeWithZoneAndSessions } from '@agor/core/db';
 import { renderWorktreeSnapshot } from '@agor/core/environment/render-snapshot';
 import type { Application } from '@agor/core/feathers';
@@ -226,8 +232,11 @@ export class WorktreesService extends DrizzleService<Worktree, Partial<Worktree>
    * so admins can set org-wide defaults in config.yaml. Explicit values on the
    * input always win; defaults fill in only when the caller omits the field.
    */
-  private async applyWorktreeCreateDefaults(data: Partial<Worktree>): Promise<Partial<Worktree>> {
-    const config = await loadConfig();
+  private async applyWorktreeCreateDefaults(
+    data: Partial<Worktree>,
+    preloadedConfig?: AgorConfig
+  ): Promise<Partial<Worktree>> {
+    const config = preloadedConfig ?? (await loadConfig());
     const defaults = config.worktrees;
     if (!defaults) return data;
 
@@ -252,8 +261,9 @@ export class WorktreesService extends DrizzleService<Worktree, Partial<Worktree>
     params?: WorktreeParams
   ): Promise<Worktree | Worktree[]> {
     if (Array.isArray(data)) {
+      const config = await loadConfig();
       const withDefaults = await Promise.all(
-        data.map((item) => this.applyWorktreeCreateDefaults(item))
+        data.map((item) => this.applyWorktreeCreateDefaults(item, config))
       );
       return super.create(withDefaults, params) as Promise<Worktree[]>;
     }