⚡ Bolt: [performance improvement] Optimize configuration loading for bulk worktree creations#65
Conversation
Move loadConfig() call outside the mapping loop during worktree bulk creation. This eliminates N-1 redundant disk I/O and YAML parsing operations when inserting an array of worktrees, reducing operation latency from O(N) to O(1). Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Updated
WorktreesService.create()to invokeloadConfig()a single time before mapping over array inputs. The loaded configuration is passed to the updatedapplyWorktreeCreateDefaultsmethod.🎯 Why
During bulk inserts (via$O(N)$ unnecessary asynchronous disk reads and YAML parsing, dragging down performance significantly as array sizes scale.
Promise.all+.map()),loadConfig()was being called on every array iteration. SinceloadConfig()reads and parses theconfig.yamlfile on every invocation, this resulted in📊 Impact
Reduces disk I/O and configuration parsing from$O(N)$ to $O(1)$ for bulk worktree creations. Prevents synchronous blocking (from the Drizzle/DB adapters mapping fast while disk I/O stacks up).
🔬 Measurement
Run
pnpm --filter @agor/daemon test -- src/services/worktrees.test.tsto verify backward compatibility and no regressions. The change handles both single object creation and array creation optimally.PR created automatically by Jules for task 10500225037097914979 started by @Donach