Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in user-manager.ts#61

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel/fix-command-injection-13176355488770085314
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in user-manager.ts#61
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel/fix-command-injection-13176355488770085314

Conversation

@Donach
Copy link
Copy Markdown

@Donach Donach commented May 26, 2026

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Command injection vulnerability identified in @agor/core/unix/user-manager.ts where the unixUserExists function passed a string-interpolated username directly into an execSync shell command (id "${username}"). This allowed arbitrary command execution if the input username broke out of the quoting.
🎯 Impact: High risk of local privilege escalation or arbitrary system command execution as the node process user, assuming an attacker was able to pass malformed input strings into contexts that relied on the check.
πŸ”§ Fix: Upgraded the shell command from execSync to execFileSync, breaking out the command components into an argument array and neutralizing shell interpretation entirely. Added a -- option boundary before the dynamic username argument to further prevent option injection risks.
βœ… Verification: Tested via unit tests and verified the fix mitigates injection payloads (e.g. $(id) or "; cat /etc/passwd #) by causing them to be interpreted as literal string targets by execFileSync.


PR created automatically by Jules for task 13176355488770085314 started by @Donach

Replaces `execSync` with `execFileSync` in `unixUserExists` to prevent shell metacharacter interpretation when checking username existence.

Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant