π‘οΈ Sentinel: [HIGH] Fix command injection in user-manager.ts#61
π‘οΈ Sentinel: [HIGH] Fix command injection in user-manager.ts#61Donach wants to merge 1 commit into
Conversation
Replaces `execSync` with `execFileSync` in `unixUserExists` to prevent shell metacharacter interpretation when checking username existence. Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Command injection vulnerability identified in
@agor/core/unix/user-manager.tswhere theunixUserExistsfunction passed a string-interpolatedusernamedirectly into anexecSyncshell command (id "${username}"). This allowed arbitrary command execution if the input username broke out of the quoting.π― Impact: High risk of local privilege escalation or arbitrary system command execution as the node process user, assuming an attacker was able to pass malformed input strings into contexts that relied on the check.
π§ Fix: Upgraded the shell command from
execSynctoexecFileSync, breaking out the command components into an argument array and neutralizing shell interpretation entirely. Added a--option boundary before the dynamicusernameargument to further prevent option injection risks.β Verification: Tested via unit tests and verified the fix mitigates injection payloads (e.g.
$(id)or"; cat /etc/passwd #) by causing them to be interpreted as literal string targets byexecFileSync.PR created automatically by Jules for task 13176355488770085314 started by @Donach