Skip to content

Fix HdfsTimeoutException not retried in setupBlockReader and EC createBlockReader #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
exmy wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −0
Open

Fix HdfsTimeoutException not retried in setupBlockReader and EC createBlockReader #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/client/InputStreamImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,15 @@ void InputStreamImpl::setupBlockReader(bool temporaryDisableLocalRead) {
}

break;
} catch (const HdfsTimeoutException & e) {
lastException = current_exception();
std::string buffer;
LOG(LOG_ERROR,
"cannot setup block reader for Block: %s file %s on Datanode: %s.\n%s\nretry another node",
curBlock->toString().c_str(), path.c_str(),
curNode.formatAddress().c_str(), GetExceptionDetail(e, buffer));
failedNodes.push_back(curNode);
failedNodes.sort();
} catch (const HdfsIOException & e) {
lastException = current_exception();
std::string buffer;
Expand Down Expand Up @@ -515,6 +524,15 @@ void InputStreamImpl::setupBlockReader(bool temporaryDisableLocalRead, shared_pt
}

break;
} catch (const HdfsTimeoutException & e) {
lastException = current_exception();
std::string buffer;
LOG(LOG_ERROR,
"cannot setup block reader for Block: %s file %s on Datanode: %s.\n%s\nretry another node",
curBlock->toString().c_str(), path.c_str(),
curNode.formatAddress().c_str(), GetExceptionDetail(e, buffer));
failedNodes.push_back(curNode);
failedNodes.sort();
} catch (const HdfsIOException & e) {
lastException = current_exception();
std::string buffer;
Expand Down
3 changes: 3 additions & 0 deletions src/client/RemoteBlockReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,9 @@ shared_ptr<PacketHeader> RemoteBlockReader::readPacketHeader() {
retval = shared_ptr<PacketHeader>(new PacketHeader);
retval->readFields(buf.data(), packetHeaderLen);
return retval;
} catch (const HdfsTimeoutException & e) {
NESTED_THROW(HdfsIOException, "RemoteBlockReader: failed to read block header for Block: %s from Datanode: %s.",
binfo.toString().c_str(), datanode.formatAddress().c_str());
} catch (const HdfsIOException & e) {
NESTED_THROW(HdfsIOException, "RemoteBlockReader: failed to read block header for Block: %s from Datanode: %s.",
binfo.toString().c_str(), datanode.formatAddress().c_str());
Expand Down
11 changes: 11 additions & 0 deletions src/client/StripedInputStreamImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,17 @@ bool StripedInputStreamImpl::createBlockReader(LocatedBlock & block,
block.getToken(), clientName, verify, *conf));
}

} catch (const HdfsTimeoutException & e) {
lastException = current_exception();
std::string buffer;
LOG(LOG_ERROR,
"cannot setup block reader for Block: %s file %s on Datanode: %s.\n%s\nretry another node",
block.toString().c_str(), path.c_str(),
node->formatAddress().c_str(), GetExceptionDetail(e, buffer));
failedNodes.push_back(*node);
failedNodes.sort();

continue;
} catch (const HdfsIOException & e) {
lastException = current_exception();
std::string buffer;
Expand Down