Fix HdfsTimeoutException not retried in setupBlockReader and EC createBlockReader#77
Open
exmy wants to merge 1 commit into
Open
Fix HdfsTimeoutException not retried in setupBlockReader and EC createBlockReader#77exmy wants to merge 1 commit into
exmy wants to merge 1 commit into
Conversation
|
xumingyong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
LGTM @alexey-milovidov pls check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HdfsTimeoutException is a sibling class of HdfsIOException (both extend
HdfsException), not a subclass. In three places where RemoteBlockReader
construction can throw HdfsTimeoutException (via checkResponse() →
readVarint32()), the exception was not caught by the existing
catch(HdfsIOException) blocks, causing the read to fail immediately
without retrying another DataNode.
This affects both replicated files (InputStreamImpl::setupBlockReader)
and Erasure Coded files (StripedInputStreamImpl::createBlockReader).
For EC files, the uncaught timeout causes chunks to be incorrectly
counted as "missing", leading to "Missing blocks, missingChunksNum >
parityBlkNum" errors even when the data is intact but DataNodes are
temporarily unresponsive.
Changes:
HdfsTimeoutException, add timed-out node to failedNodes, and retry
another DataNode.
wrap as HdfsIOException with Block/Datanode context, ensuring
timeouts during data reading are also properly handled by upstream
retry logic.