-
Notifications
You must be signed in to change notification settings - Fork 354
[ENG-7812] [ENG-9795] Notification Refactor Phase 2 - Project PR #11498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cslzchen
wants to merge
212
commits into
develop
Choose a base branch
from
feature/notifications-refactor
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15,542
−12,499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: John Tordoff <Johnetordoff@users.noreply.github.com> Co-authored-by: Ostap Zherebetskyi <ozherebetskyi@exoft.net> Co-authored-by: Bohdan Odintsov <bodintsov@exoft.net> Co-authored-by: John Tordoff <>
* Fix moderator digest * Fix unit tests
…ion (#11324) * Fix issue with user confirmation/merger creating subscription * Add docstrings
* Add No Login to notification template and add to tests
…tion-refactor-p2-s * Conflicts have not been resolved in this merge since we want to track how we fixed the conflicts due to complexity * api/nodes/serializers.py * osf/models/user.py * tests/test_auth.py * tests/test_webtests.py * website/templates/node_request_institutional_access_request.html.mako
…plate-with-naming [ENG-8988] Fix/notification contrib template with naming
[ENG-8997] Turn on script tests
[ENG-8996] Fix moderator added template
[ENG-9005] Fix/update v2 subscriptions
…tests [ENG-9603] Fix Reset Password Tests
…om/centerforopenscience/osf.io into fix-test-add-contributors-notifications
…-notifications [ENG-9600][ENG-9606] Notification refactor fix contributor adding issues
…om/centerforopenscience/osf.io into fix-institutional-request-templates
…-templates [ENG-9605] Fix institutional node request updates template
…ionSubscriptionLegacy_migrations [ENG-9965] Update the model's metadata options to avoid migrations
[ENG-9959] Add missing emails/tasks/signals
…lved_conflicts [ENG-9920] merge conflicts
…ions [ENG-9966] Implement contributor notification for admin
…-naming [ENG-9968] Fix beat_schedule key name for send_no_addon_email
…te_form [ENG-9972] Fix registration update date in the admin app
…tests [ENG-9933] Fix/hotfix 25.18.2 tests
…ands [ENG-9969] revert management commands removal
[ENG-9977] Update defaults for no login email config
…cation_types [ENG-9970] Disable `post_migrate` that populates notification types and if possible make it a waffle switch/flag.
Ostap-Zherebetskyi
approved these changes
Dec 24, 2025
Collaborator
Ostap-Zherebetskyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
TBD
Changes
TBD
QA Notes
TBD
Documentation
TBD
Side Effects
TBD
Ticket
https://openscience.atlassian.net/browse/ENG-7812
https://openscience.atlassian.net/browse/ENG-9795