[ENG-9795] Notification Refactor Phase 2 #11460
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: John Tordoff <Johnetordoff@users.noreply.github.com> Co-authored-by: Ostap Zherebetskyi <ozherebetskyi@exoft.net> Co-authored-by: Bohdan Odintsov <bodintsov@exoft.net> Co-authored-by: John Tordoff <>
* Fix moderator digest * Fix unit tests
…ion (#11324) * Fix issue with user confirmation/merger creating subscription * Add docstrings
* Add No Login to notification template and add to tests
…tion-refactor-p2-s * Conflicts have not been resolved in this merge since we want to track how we fixed the conflicts due to complexity * api/nodes/serializers.py * osf/models/user.py * tests/test_auth.py * tests/test_webtests.py * website/templates/node_request_institutional_access_request.html.mako
…plate-with-naming [ENG-8988] Fix/notification contrib template with naming
[ENG-8997] Turn on script tests
[ENG-8996] Fix moderator added template
[ENG-9005] Fix/update v2 subscriptions
…tests [ENG-9603] Fix Reset Password Tests
…om/centerforopenscience/osf.io into fix-test-add-contributors-notifications
…-notifications [ENG-9600][ENG-9606] Notification refactor fix contributor adding issues
…om/centerforopenscience/osf.io into fix-institutional-request-templates
…-templates [ENG-9605] Fix institutional node request updates template
…st_filter [ENG-9895] add manual filtering for event_name in subscription list
…t_recipients [ENG-9888] add admin-moderator group
…ions_url [ENG-9896] Wrong links in the digest email for provider submission
…n_notification_model [ENG-9882] improve error handling and display for Notification admin fields
…pe_cache [ENG-9883] replace cached_property with ttl_cached_property
…assertion [ENG-9909] validate user email addresses in notification tasks and subscriptions
…assertion [ENG-9909] handle user email validation
… notifications that are never supposed to be sent
…e_cleanup [ENG-9853] remove unused notification types and comments
[ENG-9921] Improve how no login email is configured and sent
…nt_date [ENG-9922] Set an obviously "WRONG" time for property "sent"
…ates [ENG-9921] ensure distinct users are returned in no_login email task
[ENG-9921][ENG-9954] update user last login field and improve no_login email content
[ENG-9953] Fix node notifications
Collaborator
Author
|
This draft PR is for internal review only, which has been finished. Project PR continues in #11498. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Notification Refactor Phase 2 Project PR for CR
Ticket
https://openscience.atlassian.net/browse/ENG-9795