-
Notifications
You must be signed in to change notification settings - Fork 15
ENH: Update CastXML to fix MSVC Stack size testing issue #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@bradking I was unable to replicate this error on my local Windows VS 2022 build of this same codebase. I am not familiar with how this system works, but it seems like the CI is giving a warning ab the use of "-c" flag that is not used in windows builds that is corrupting the expected output. This is a failing test, even though I think that the code would working. I'd love some advice in how to get this failing test to pass on the github CI. Thanks, |
|
That test was added by CastXML/CastXML#219, and the failure looks much like the problem that change was meant to fix. Please check the |
|
Or, I wonder if GitHub Actions is somehow limiting the stack size of the process. |
616849c to
5f6a3b7
Compare
b12ea89 to
84dd6a4
Compare
Support exclusion of large stack requirement tests on github CI environments.
84dd6a4 to
7c667d3
Compare
hjmjohnson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thewtex I think this is ready for review and merging.
dzenanz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Deferring merging to Matt/Brad.
Uh oh!
There was an error while loading. Please reload this page.