test: Label tests requiring a large stack size #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
See build test with CastXMLSuperbuild: |
bradking
reviewed
Dec 20, 2025
hjmjohnson
force-pushed
the
216-Followup-MSVC-fix
branch
2 times, most recently
from
326d18e to
60944e0
Compare
Contributor
Author
Contributor
Author
|
Full test in CastXMLSuperBuild with this code: This enables disabling this test on github workflows: |
bradking
changed the title
The `cmd.fbracket-depth` test intentionally uses a large amount of stack space. With MSVC tools, the `-STACK:10000000` link flag is required. However, GitHub Actions imposes a lower stack size limit. Label the test so it can be excluded.
bradking
force-pushed
the
216-Followup-MSVC-fix
branch
from
60944e0 to
084ccfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cmd.fbracket-depthtest intentionally uses a large amount of stackspace. With MSVC tools, the
-STACK:10000000link flag is required.However, GitHub Actions imposes a lower stack size limit. Label the
test so it can be excluded.
Original Description
Followup on commit 5f551bd to ensure that the stack size linkage flag is respected.
Github CI appears to have a smaller default stack size than typical MSVC environments.
Flag should be /STACK:### instead of -STACK:###
The test cmd.fbracket-depth can be forced to fail by setting
CMAKE_EXE_LINKER_FLAGS to /STACK:100
Additionally, CMAKE_EXE_LINKER_FLAGS needs to be set with CACHE
for the value to persist into the CMakeCache.txt. Without set(CACHE)
statement, the CMakeCache.txt did not include the requested
/STACK:###