Skip to content

(WIP) APP-432 - Validate /nbs/api/report/execute requests#3140

Draft
JordanGuinn wants to merge 15 commits intomainfrom
jg/APP-432
Draft

(WIP) APP-432 - Validate /nbs/api/report/execute requests#3140
JordanGuinn wants to merge 15 commits intomainfrom
jg/APP-432

Conversation

@JordanGuinn
Copy link
Copy Markdown
Contributor

@JordanGuinn JordanGuinn commented Apr 7, 2026

Description

This PR adds some initial validation to the /nbs/api/report/execute API, particularly around the shape of the incoming request, along with the presence and format of expected fields.

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@JordanGuinn JordanGuinn changed the title APP-432 - Validate /nbs/api/report/execute requests (WIP) APP-432 - Validate /nbs/api/report/execute requests Apr 7, 2026
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
40.0% Coverage on New Code (required ≥ 90%)
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant