Skip to content

APP-184 Automated e2e for Data Entry - Lab Report#3114

Merged
krista-skylight merged 14 commits intomainfrom
kc/lab-entry-e2e-tests
Apr 22, 2026
Merged

APP-184 Automated e2e for Data Entry - Lab Report#3114
krista-skylight merged 14 commits intomainfrom
kc/lab-entry-e2e-tests

Conversation

@krista-skylight
Copy link
Copy Markdown
Contributor

@krista-skylight krista-skylight commented Mar 26, 2026

Description

Lab Report e2e tests copied over from here and partially modified to work on NBS7.

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

Krista Chan and others added 2 commits March 26, 2026 12:32
@sonarqubecloud
Copy link
Copy Markdown

@krista-skylight krista-skylight marked this pull request as ready for review April 14, 2026 22:46
@krista-skylight krista-skylight requested a review from a team as a code owner April 14, 2026 22:46
@krista-skylight krista-skylight requested review from brick-green and emyl3 and removed request for a team April 14, 2026 22:46
@krista-skylight krista-skylight changed the title Open APP-184 Automated e2e for Data Entry - Lab Report APP-184 Automated e2e for Data Entry - Lab Report Apr 14, 2026
cy.log('First patient ID hyperlink clicked');
}

// // Function to safely navigate to Events tab
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question, blocking: uncomment or delete this section?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, deleted! thanks!

Removed the commented-out navigateToEventsTab function that contained logic for navigating to the Events tab.
"eslint-plugin-cypress": "^4.3.0",
"multiple-cucumber-html-reporter": "^3.6.2"
"multiple-cucumber-html-reporter": "^3.6.2",
"react": "^19.2.5",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Did we need to add these to fix some of the issues you were seeing for why these tests were failing in 7? 👀

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krista-skylight I'm just waiting on this question before approving

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Krista's response!! 😸

image

Scenario: Adding a Lab Report with detailed fields
When I click on Data Entry in the menu bar
Scenario: Create lab report and confirm association
And I search by last name as "Singh"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look like this is failing for me locally...

Image

Have you run into this Krista? 🤔

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, all the tests passed locally for me

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what is wrong with my setup 😭

@krista-skylight krista-skylight requested a review from emyl3 April 16, 2026 19:02
Copy link
Copy Markdown
Contributor

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Krista!

Copy link
Copy Markdown
Contributor

@brick-green brick-green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@krista-skylight krista-skylight merged commit 393e421 into main Apr 22, 2026
1 check passed
@krista-skylight krista-skylight deleted the kc/lab-entry-e2e-tests branch April 22, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants