Remove RDB migrations#844
Open
ericbuckley wants to merge 2 commits into
Open
Conversation
…sion to 16.1 Consolidates reporting database migrations by removing legacy `004-rdb` scripts and directing both `rdb` and `rdb_modern` targets to use the unified `005-rdb_modern` changelogs. Key changes: - Removed the `004-rdb` SQL scripts and `db.rdb.changelog-16.1.yaml`. - Implemented dynamic target database detection in `migrate.sh` using the environment configuration in `NBS_ODSE`. - Updated `build.gradle` and changelogs to reflect `NBS_DB_VER` 16.1. - Streamlined `Dockerfile` and manual deployment scripts (`upgrade_db.sh`, `upgrade_db.bat`) to follow the unified migration path. - Updated `readme.md` and manual deployment documentation to reflect the simplified architecture. This change reduces maintenance complexity and ensures consistent object deployment regardless of whether the target reporting database is named `rdb` or `rdb_modern`.
Add an initialization script to apply missing RDB migrations from R6.0.8. These changes increase the length of various columns in LAB_TEST, INVESTIGATION, and related tables to VARCHAR(199) to support longer identifiers and test method codes. This ensures the local development environment matches the official database schema used for ELR processing and act_id extensions. Refs: ND-18353, ND-18817
mpeels
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the RDB liquibase migrations. There was really just 1 migration being applied and that was to correct for an inconsistency in the development database image. Moving that migration to containers/db/initialize makes more sense, as we don't need users to run it.
Additional Notes
004-rdbdirectory and associated configurations have been removed. This was necessary to resolve inconsistencies between legacy RDB structures and our current event-driven reporting requirements.Checklist