Improve error handling in ..esi trunk create #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skanthed
force-pushed
the
fix-trunk-create-error
branch
from
35f3899 to
d5800ab
Compare
… messages - Use `ignore_missing=False` in find_network to raise OpenStack SDK errors - Removes silent fallback to None
skanthed
force-pushed
the
fix-trunk-create-error
branch
from
d5800ab to
66787b1
Compare
Member
|
The associated issue for this PR is CCI-MOC/esi#664, which provides two examples in which we are hiding relevant error messages from the user. It looks like this PR only addresses the second of those two situations (the failure of Were you able to reproduce the first error? |
Collaborator
Author
|
Yes I was and will be addressed in the new PR. |
|
@skanthed can you please link the other PR? |
Collaborator
Author
|
Yes I will link it by tomorrow. Just finishing something. |
Collaborator
Author
|
node network attach fix - CCI-MOC/esisdk#25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows Neutron's error messages to surface properly during invalid network references.
ignore_missing=Falsein find_network to raise OpenStack SDK errors