Improve error handling for invalid network in esi trunk create #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzumainn
requested changes
Dec 16, 2024
Contributor
tzumainn
left a comment
tzumainn
left a comment
There was a problem hiding this comment.
I think this may not address the direct issue. The problem is that there is an error message being handed to us in the response; we're just not showing it. Can you find a more generic solution that catches the NeutronErrors that Lars is pointing out, and printing them out?
Member
|
@skanthed eric munson just hit this same issue (slack thread); have you made any progress on these changes? |
Collaborator
Author
|
it's resolved here - #88 |
Member
|
Whoops, please ignore that last comment, which possibly I have just deleted :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.