Skip to content

fix: add ENV=production to Kubernetes deployment for secure session cookies #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hell1213 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

fix: add ENV=production to Kubernetes deployment for secure session cookies #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions production/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
1. Create a file named `.backend.env` with the following attributes:

```bash
ENV="production" # Required for secure HTTPS-only cookies
CLIENT_ID="client_ID" # Google Auth Secret from Prerequisites
CLIENT_SEC="client_SECRET" # Google Auth Secret from Prerequisites
REDIRECT_URL_DEV="http://localhost:8000/auth/callback"
Expand Down Expand Up @@ -84,6 +85,7 @@ services:

Create `.backend.env`:
```bash
ENV="production"
CLIENT_ID="your-google-client-id"
CLIENT_SEC="your-google-client-secret"
REDIRECT_URL_DEV="https://your-domain.com/auth/callback"
Expand Down
5 changes: 5 additions & 0 deletions production/backend-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ spec:
configMapKeyRef:
key: CONTAINER_ORIGIN
name: backend-env
- name: ENV
valueFrom:
configMapKeyRef:
key: ENV
name: backend-env
- name: FRONTEND_ORIGIN_DEV
valueFrom:
configMapKeyRef:
Expand Down
1 change: 1 addition & 0 deletions production/backend-env-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ data:
CLIENT_ID: "YOUR_GOOGLE_CLOUD_AUTH_CLIENT_ID" # Replace this in order to access the frontend
CLIENT_SEC: "YOUR_GOOGLE_CLOUD_AUTH_CLIENT_SECRET" # Replace this in order to access the frontend
CONTAINER_ORIGIN: http://syncserver:8080/
ENV: "production" # Required for secure HTTPS-only cookies
FRONTEND_ORIGIN_DEV: http://localhost
PORT: "8000"
REDIRECT_URL_DEV: http://localhost:8000/auth/callback
Expand Down
Loading