Skip to content

Conversation

@Hell1213
Copy link
Contributor

Description

Added ENV=production to Kubernetes deployment configuration to enable secure HTTPS-only session cookies, fixing session persistence issues.

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (for JS/TS testing)
  • Added unit tests, if applicable
  • Verified all tests pass
  • Updated documentation, if needed

Additional Notes

Without ENV=production, session cookies had Secure=false, causing browsers to reject them on HTTPS sites. This resulted in users having to log in on every visit.

Changes:

  • Added ENV variable to backend-env-configmap.yaml
  • Added ENV reference to backend-deployment.yaml
  • Updated production README with ENV configuration

@github-actions
Copy link

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

Copy link
Contributor Author

@Hell1213 Hell1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing ENV=production to K8s deployment config. This enables secure cookies for HTTPS, fixing the session persistence issue where users had to log in every visit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I have to log in all the time

1 participant