Skip to content

Fix: Set correct hwnd for temporary webview2 controller #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Sep 20, 2025
Merged

Fix: Set correct hwnd for temporary webview2 controller #3169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61f95e6
Fix: Set correct hwnd for temporary webview2 controller
BornToBeRoot Sep 20, 2025
3bb958f
Docs: #3169
BornToBeRoot Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Source/NETworkManager/ViewModels/WebConsoleSettingsViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
using NETworkManager.Settings;
using NETworkManager.Utilities;
using NETworkManager.Views;
using System;
using System.Threading.Tasks;
using System.Windows;
using System.Windows.Input;
using System.Windows.Interop;

namespace NETworkManager.ViewModels;

Expand Down Expand Up @@ -118,7 +118,10 @@ private Task DeleteBrowsingData()
// Create a temporary WebView2 instance to clear browsing data
var webView2Environment =
await CoreWebView2Environment.CreateAsync(null, GlobalStaticConfiguration.WebConsole_Cache);
var webView2Controller = await webView2Environment.CreateCoreWebView2ControllerAsync(IntPtr.Zero);

var windowHwnd = new WindowInteropHelper(Application.Current.MainWindow).Handle;

var webView2Controller = await webView2Environment.CreateCoreWebView2ControllerAsync(windowHwnd);

await webView2Controller.CoreWebView2.Profile.ClearBrowsingDataAsync();

Expand Down
3 changes: 3 additions & 0 deletions Website/docs/changelog/next-release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ Release date: **xx.xx.2025**

## Bugfixes

- **Web Console**
- Fixed an issue where clearing the Browser cache crashed the application. [#3169](https://github.com/BornToBeRoot/NETworkManager/pull/3169)

- **Profiles**
- Fixed an issue where only one profile was deleted in `Settings > Profiles` when multiple profiles were selected. [#3144](https://github.com/BornToBeRoot/NETworkManager/pull/3144) [#3145](https://github.com/BornToBeRoot/NETworkManager/issues/3145)

Expand Down