Skip to content

Conversation

@BornToBeRoot
Copy link
Owner

Changes proposed in this pull request

  • Set correct hwnd for temporary webview2 controller

Related issue(s)

Copilot generated summary

Provide a Copilot generated summary of the changes in this pull request.

Copilot summary

This pull request updates the way the application handles the deletion of browsing data in the web console settings. The main change is that the code now passes the main window handle when creating the WebView2 controller, which improves compatibility and stability when clearing browsing data.

Improvements to WebView2 controller initialization:

  • Updated DeleteBrowsingData() in WebConsoleSettingsViewModel.cs to use the main window handle (WindowInteropHelper(Application.Current.MainWindow).Handle) when creating the WebView2 controller, instead of passing IntPtr.Zero. This change ensures the controller is properly associated with the application's main window.
  • Removed the unnecessary using System; directive from WebConsoleSettingsViewModel.cs, as it is no longer needed after the change.

To-Do

Contributing

By submitting this pull request, I confirm the following:

@mergify mergify bot merged commit b46368e into main Sep 20, 2025
4 checks passed
@mergify mergify bot deleted the fix/3168 branch September 20, 2025 22:38
@BornToBeRoot BornToBeRoot added this to the next-release milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Delete browsing data" in Settings (Web Console) crashes NETworkManager

2 participants